Re: [PATCH 01/11] hw/m68k/next-cube: Make next_irq() function static

[Thomas Huth]

Am Fri, 15 Jan 2021 20:11:56 +
schrieb Peter Maydell :

> The next_irq() function is global, but isn't actually used anywhere
> outside next-cube.c. Make it static.
> 
> Signed-off-by: Peter Maydell 
> ---
>  include/hw/m68k/next-cube.h | 2 --
>  hw/m68k/next-cube.c | 2 +-
>  2 files changed, 1 insertion(+), 3 deletions(-)

Reviewed-by: Thomas Huth 

[PATCH 01/11] hw/m68k/next-cube: Make next_irq() function static

[Peter Maydell]

The next_irq() function is global, but isn't actually used anywhere
outside next-cube.c. Make it static.

Signed-off-by: Peter Maydell 
---
 include/hw/m68k/next-cube.h | 2 --
 hw/m68k/next-cube.c | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/include/hw/m68k/next-cube.h b/include/hw/m68k/next-cube.h
index a3be2b32abb..5a56c354b8e 100644
--- a/include/hw/m68k/next-cube.h
+++ b/include/hw/m68k/next-cube.h
@@ -42,6 +42,4 @@ enum next_irqs {
 NEXT_SND_I
 };
 
-void next_irq(void *opaque, int number, int level);
-
 #endif /* NEXT_CUBE_H */
diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c
index 37bc35dfa43..f622d6589c8 100644
--- a/hw/m68k/next-cube.c
+++ b/hw/m68k/next-cube.c
@@ -724,7 +724,7 @@ static const MemoryRegionOps dma_ops = {
  * TODO: set the shift numbers as values in the enum, so the first switch
  * will not be needed
  */
-void next_irq(void *opaque, int number, int level)
+static void next_irq(void *opaque, int number, int level)
 {
 M68kCPU *cpu = opaque;
 int shift = 0;
-- 
2.20.1