Re: [PATCH 01/13] block/stream: Remove redundant statement in stream_run()
On 2/24/20 9:09 PM, kuhn.chen...@huawei.com wrote: > From: Chen Qun > > Clang static code analyzer show warning: > block/stream.c:186:9: warning: Value stored to 'ret' is never read > ret = 0; > ^ ~ > Reported-by: Euler Robot > Signed-off-by: Chen Qun > --- > Cc: John Snow > Cc: Kevin Wolf > Cc: Max Reitz > Cc: qemu-bl...@nongnu.org > --- > block/stream.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/block/stream.c b/block/stream.c > index 5562ccbf57..d78074ac80 100644 > --- a/block/stream.c > +++ b/block/stream.c > @@ -183,7 +183,6 @@ static int coroutine_fn stream_run(Job *job, Error **errp) > break; > } > } > -ret = 0; > > /* Publish progress */ > job_progress_update(>common.job, n); > Reviewed-by: John Snow
[PATCH 01/13] block/stream: Remove redundant statement in stream_run()
From: Chen Qun Clang static code analyzer show warning: block/stream.c:186:9: warning: Value stored to 'ret' is never read ret = 0; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: John Snow Cc: Kevin Wolf Cc: Max Reitz Cc: qemu-bl...@nongnu.org --- block/stream.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/stream.c b/block/stream.c index 5562ccbf57..d78074ac80 100644 --- a/block/stream.c +++ b/block/stream.c @@ -183,7 +183,6 @@ static int coroutine_fn stream_run(Job *job, Error **errp) break; } } -ret = 0; /* Publish progress */ job_progress_update(>common.job, n); -- 2.23.0