Re: [PATCH 02/10] exec/ramblock: Add missing 'qemu/rcu.h' include

[Juan Quintela]

Philippe Mathieu-Daudé  wrote:
> The first field of RAMBlock is a rcu_head structure.
> We need to include the "qemu/rcu.h" to avoid errors when
> including "exec/ramblock.h" without "qemu/rcu.h":
>
>   include/exec/ramblock.h:27:21: error: field ‘rcu’ has incomplete type
>  27 | struct rcu_head rcu;
> | ^~~
>   include/exec/ramblock.h:39:5: error: expected
> specifier-qualifier-list before ‘QLIST_ENTRY’
>  39 | QLIST_ENTRY(RAMBlock) next;
> | ^~~
>
> Signed-off-by: Philippe Mathieu-Daudé 

Reviewed-by: Juan Quintela 

[PATCH 02/10] exec/ramblock: Add missing 'qemu/rcu.h' include

[Philippe Mathieu-Daudé]

The first field of RAMBlock is a rcu_head structure.
We need to include the "qemu/rcu.h" to avoid errors when
including "exec/ramblock.h" without "qemu/rcu.h":

  include/exec/ramblock.h:27:21: error: field ‘rcu’ has incomplete type
 27 | struct rcu_head rcu;
| ^~~
  include/exec/ramblock.h:39:5: error: expected specifier-qualifier-list before 
‘QLIST_ENTRY’
 39 | QLIST_ENTRY(RAMBlock) next;
| ^~~

Signed-off-by: Philippe Mathieu-Daudé 
---
 include/exec/ramblock.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/exec/ramblock.h b/include/exec/ramblock.h
index 07d50864d8..6ac0aa7a89 100644
--- a/include/exec/ramblock.h
+++ b/include/exec/ramblock.h
@@ -21,6 +21,7 @@
 
 #ifndef CONFIG_USER_ONLY
 #include "cpu-common.h"
+#include "qemu/rcu.h"
 
 struct RAMBlock {
 struct rcu_head rcu;
-- 
2.21.3