Re: [PATCH 02/10] tests/throttle: Clean up global variable shadowing

[Alberto Garcia]

On Mon 09 Oct 2023 12:02:43 PM +02, Philippe Mathieu-Daudé wrote:
> Follow all other tests pattern from this file, use the
> global 'cfg' variable to fix:
>
>   tests/unit/test-throttle.c:621:20: error: declaration shadows a variable in 
> the global scope [-Werror,-Wshadow]
>   ThrottleConfig cfg;
>  ^
>   tests/unit/test-throttle.c:28:23: note: previous declaration is here
>   static ThrottleConfig cfg;
> ^
>
> Signed-off-by: Philippe Mathieu-Daudé 

Acked-by: Alberto Garcia 

Berto

[PATCH 02/10] tests/throttle: Clean up global variable shadowing

[Philippe Mathieu-Daudé]

Follow all other tests pattern from this file, use the
global 'cfg' variable to fix:

  tests/unit/test-throttle.c:621:20: error: declaration shadows a variable in 
the global scope [-Werror,-Wshadow]
  ThrottleConfig cfg;
 ^
  tests/unit/test-throttle.c:28:23: note: previous declaration is here
  static ThrottleConfig cfg;
^

Signed-off-by: Philippe Mathieu-Daudé 
---
 tests/unit/test-throttle.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/unit/test-throttle.c b/tests/unit/test-throttle.c
index ac35d65d19..2146cfacd3 100644
--- a/tests/unit/test-throttle.c
+++ b/tests/unit/test-throttle.c
@@ -618,7 +618,6 @@ static bool do_test_accounting(bool is_ops, /* are we 
testing bps or ops */
  { THROTTLE_OPS_TOTAL,
THROTTLE_OPS_READ,
THROTTLE_OPS_WRITE, } };
-ThrottleConfig cfg;
 BucketType index;
 int i;
 
-- 
2.41.0