Re: [PATCH 04/33] Declarations of h2t and t2h conversion functions.

2023-08-08 Thread Richard Henderson

On 8/7/23 23:07, Karim Taha wrote:

From: Stacey Son 

Declarations of functions that convert between host and target structs.

Signed-off-by: Stacey Son 
Signed-off-by: Karim Taha 
---
  bsd-user/freebsd/qemu-os.h | 35 +++
  bsd-user/qemu.h|  1 +
  2 files changed, 36 insertions(+)
  create mode 100644 bsd-user/freebsd/qemu-os.h

diff --git a/bsd-user/freebsd/qemu-os.h b/bsd-user/freebsd/qemu-os.h
new file mode 100644
index 00..7ef4c55350
--- /dev/null
+++ b/bsd-user/freebsd/qemu-os.h
@@ -0,0 +1,35 @@
+/*
+ *  FreeBSD conversion extern declarations
+ *
+ *  Copyright (c) 2013 Stacey D. Son
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation; either version 2 of the License, or
+ *  (at your option) any later version.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program; if not, see .
+ */
+
+#ifndef QEMU_OS_H
+#define QEMU_OS_H
+
+/* qemu/osdep.h pulls in the rest */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+struct freebsd11_stat;
+
+#endif /* QEMU_OS_H */
diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
index c41ebfe937..1344c3fce6 100644
--- a/bsd-user/qemu.h
+++ b/bsd-user/qemu.h
@@ -38,6 +38,7 @@ extern char **environ;
  #include "exec/gdbstub.h"
  #include "qemu/clang-tsa.h"
  
+#include "qemu-os.h"

  /*
   * This struct is used to hold certain information about the image.  
Basically,
   * it replicates in user space what would be certain task_struct fields in the


The subject and comment do not match the patch, or at least not obviously.
This appears to merely include some extra system headers, not declare any sort of 
coversion functions.



r~



[PATCH 04/33] Declarations of h2t and t2h conversion functions.

2023-08-08 Thread Karim Taha
From: Stacey Son 

Declarations of functions that convert between host and target structs.

Signed-off-by: Stacey Son 
Signed-off-by: Karim Taha 
---
 bsd-user/freebsd/qemu-os.h | 35 +++
 bsd-user/qemu.h|  1 +
 2 files changed, 36 insertions(+)
 create mode 100644 bsd-user/freebsd/qemu-os.h

diff --git a/bsd-user/freebsd/qemu-os.h b/bsd-user/freebsd/qemu-os.h
new file mode 100644
index 00..7ef4c55350
--- /dev/null
+++ b/bsd-user/freebsd/qemu-os.h
@@ -0,0 +1,35 @@
+/*
+ *  FreeBSD conversion extern declarations
+ *
+ *  Copyright (c) 2013 Stacey D. Son
+ *
+ *  This program is free software; you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation; either version 2 of the License, or
+ *  (at your option) any later version.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program; if not, see .
+ */
+
+#ifndef QEMU_OS_H
+#define QEMU_OS_H
+
+/* qemu/osdep.h pulls in the rest */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+struct freebsd11_stat;
+
+#endif /* QEMU_OS_H */
diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
index c41ebfe937..1344c3fce6 100644
--- a/bsd-user/qemu.h
+++ b/bsd-user/qemu.h
@@ -38,6 +38,7 @@ extern char **environ;
 #include "exec/gdbstub.h"
 #include "qemu/clang-tsa.h"
 
+#include "qemu-os.h"
 /*
  * This struct is used to hold certain information about the image.  Basically,
  * it replicates in user space what would be certain task_struct fields in the
-- 
2.40.0