Re: [PATCH 05/11] hw/arm/sbsa-ref: Use qdev_prop_set_array()

[Peter Maydell]

On Fri, 8 Sept 2023 at 15:37, Kevin Wolf  wrote:
>
> Instead of manually setting "foo-len" and "foo[i]" properties, build a
> QList and use the new qdev_prop_set_array() helper to set the whole
> array property with a single call.
>
> Signed-off-by: Kevin Wolf 
> ---

Reviewed-by: Peter Maydell 

thanks
-- PMM

[PATCH 05/11] hw/arm/sbsa-ref: Use qdev_prop_set_array()

[Kevin Wolf]

Instead of manually setting "foo-len" and "foo[i]" properties, build a
QList and use the new qdev_prop_set_array() helper to set the whole
array property with a single call.

Signed-off-by: Kevin Wolf 
---
 hw/arm/sbsa-ref.c | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
index bc89eb4806..354c1a037d 100644
--- a/hw/arm/sbsa-ref.c
+++ b/hw/arm/sbsa-ref.c
@@ -46,6 +46,7 @@
 #include "hw/char/pl011.h"
 #include "hw/watchdog/sbsa_gwdt.h"
 #include "net/net.h"
+#include "qapi/qmp/qlist.h"
 #include "qom/object.h"
 
 #define RAMLIMIT_GB 8192
@@ -441,6 +442,7 @@ static void create_gic(SBSAMachineState *sms, MemoryRegion 
*mem)
 SysBusDevice *gicbusdev;
 const char *gictype;
 uint32_t redist0_capacity, redist0_count;
+QList *redist_region_count;
 int i;
 
 gictype = gicv3_class_name();
@@ -459,8 +461,9 @@ static void create_gic(SBSAMachineState *sms, MemoryRegion 
*mem)
 sbsa_ref_memmap[SBSA_GIC_REDIST].size / GICV3_REDIST_SIZE;
 redist0_count = MIN(smp_cpus, redist0_capacity);
 
-qdev_prop_set_uint32(sms->gic, "len-redist-region-count", 1);
-qdev_prop_set_uint32(sms->gic, "redist-region-count[0]", redist0_count);
+redist_region_count = qlist_new();
+qlist_append_int(redist_region_count, redist0_count);
+qdev_prop_set_array(sms->gic, "redist-region-count", redist_region_count);
 
 object_property_set_link(OBJECT(sms->gic), "sysmem",
  OBJECT(mem), &error_fatal);
-- 
2.41.0