Re: [PATCH 07/12] crypto: drop used conditional check

[Richard Henderson]

On 5/11/21 8:26 AM, Daniel P. Berrangé wrote:

The condition being tested has never been set since the day the code was
first introduced.

Signed-off-by: Daniel P. Berrangé
---
  crypto/tlscredsx509.c | 2 --
  1 file changed, 2 deletions(-)


Reviewed-by: Richard Henderson 

r~

Re: [PATCH 07/12] crypto: drop used conditional check

[Willian Rampazzo]

On Tue, May 11, 2021 at 10:28 AM Daniel P. Berrangé  wrote:
>
> The condition being tested has never been set since the day the code was
> first introduced.
>
> Signed-off-by: Daniel P. Berrangé 
> ---
>  crypto/tlscredsx509.c | 2 --
>  1 file changed, 2 deletions(-)
>

Reviewed-by: Willian Rampazzo 

[PATCH 07/12] crypto: drop used conditional check

[Daniel P . Berrangé]

The condition being tested has never been set since the day the code was
first introduced.

Signed-off-by: Daniel P. Berrangé 
---
 crypto/tlscredsx509.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/crypto/tlscredsx509.c b/crypto/tlscredsx509.c
index bc503bab55..d9d6f4421e 100644
--- a/crypto/tlscredsx509.c
+++ b/crypto/tlscredsx509.c
@@ -354,11 +354,9 @@ qcrypto_tls_creds_check_cert_pair(gnutls_x509_crt_t cert,
 reason = "The certificate has been revoked";
 }
 
-#ifndef GNUTLS_1_0_COMPAT
 if (status & GNUTLS_CERT_INSECURE_ALGORITHM) {
 reason = "The certificate uses an insecure algorithm";
 }
-#endif
 
 error_setg(errp,
"Our own certificate %s failed validation against %s: %s",
-- 
2.31.1