Re: [PATCH 07/13] target/arm: Convert BFDOT to decodetree

2024-06-25 Thread Peter Maydell
On Tue, 25 Jun 2024 at 06:09, Richard Henderson
 wrote:
>
> Signed-off-by: Richard Henderson 
> ---
>  target/arm/tcg/a64.decode  |  2 ++
>  target/arm/tcg/translate-a64.c | 20 +---
>  2 files changed, 7 insertions(+), 15 deletions(-)

Reviewed-by: Peter Maydell 

thanks
-- PMM



[PATCH 07/13] target/arm: Convert BFDOT to decodetree

2024-06-24 Thread Richard Henderson
Signed-off-by: Richard Henderson 
---
 target/arm/tcg/a64.decode  |  2 ++
 target/arm/tcg/translate-a64.c | 20 +---
 2 files changed, 7 insertions(+), 15 deletions(-)

diff --git a/target/arm/tcg/a64.decode b/target/arm/tcg/a64.decode
index 8a0251f83c..6819fd2587 100644
--- a/target/arm/tcg/a64.decode
+++ b/target/arm/tcg/a64.decode
@@ -950,6 +950,7 @@ SQRDMLSH_v  0.10 1110 ..0 . 10001 1 . . 
@qrrr_e
 SDOT_v  0.00 1110 100 . 10010 1 . . @qrrr_s
 UDOT_v  0.10 1110 100 . 10010 1 . . @qrrr_s
 USDOT_v 0.00 1110 100 . 10011 1 . . @qrrr_s
+BFDOT_v 0.10 1110 010 . 1 1 . . @qrrr_s
 
 ### Advanced SIMD scalar x indexed element
 
@@ -1029,6 +1030,7 @@ SDOT_vi 0.00  10 ..  1110 . 0 . . 
  @qrrx_s
 UDOT_vi 0.10  10 ..  1110 . 0 . .   @qrrx_s
 SUDOT_vi0.00  00 ..   . 0 . .   @qrrx_s
 USDOT_vi0.00  10 ..   . 0 . .   @qrrx_s
+BFDOT_vi0.00  01 ..   . 0 . .   @qrrx_s
 
 # Floating-point conditional select
 
diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
index 9a658ca876..0f44cd5aee 100644
--- a/target/arm/tcg/translate-a64.c
+++ b/target/arm/tcg/translate-a64.c
@@ -5604,6 +5604,7 @@ static bool do_dot_vector(DisasContext *s, arg_qrrr_e *a,
 TRANS_FEAT(SDOT_v, aa64_dp, do_dot_vector, a, gen_helper_gvec_sdot_b)
 TRANS_FEAT(UDOT_v, aa64_dp, do_dot_vector, a, gen_helper_gvec_udot_b)
 TRANS_FEAT(USDOT_v, aa64_i8mm, do_dot_vector, a, gen_helper_gvec_usdot_b)
+TRANS_FEAT(BFDOT_v, aa64_bf16, do_dot_vector, a, gen_helper_gvec_bfdot)
 
 /*
  * Advanced SIMD scalar/vector x indexed element
@@ -5942,6 +5943,8 @@ TRANS_FEAT(SUDOT_vi, aa64_i8mm, do_dot_vector_idx, a,
gen_helper_gvec_sudot_idx_b)
 TRANS_FEAT(USDOT_vi, aa64_i8mm, do_dot_vector_idx, a,
gen_helper_gvec_usdot_idx_b)
+TRANS_FEAT(BFDOT_vi, aa64_bf16, do_dot_vector_idx, a,
+   gen_helper_gvec_bfdot_idx)
 
 /*
  * Advanced SIMD scalar pairwise
@@ -10951,11 +10954,11 @@ static void 
disas_simd_three_reg_same_extra(DisasContext *s, uint32_t insn)
 break;
 case 0x1f:
 switch (size) {
-case 1: /* BFDOT */
 case 3: /* BFMLAL{B,T} */
 feature = dc_isar_feature(aa64_bf16, s);
 break;
 default:
+case 1: /* BFDOT */
 unallocated_encoding(s);
 return;
 }
@@ -11036,9 +11039,6 @@ static void 
disas_simd_three_reg_same_extra(DisasContext *s, uint32_t insn)
 return;
 case 0xf:
 switch (size) {
-case 1: /* BFDOT */
-gen_gvec_op4_ool(s, is_q, rd, rn, rm, rd, 0, 
gen_helper_gvec_bfdot);
-break;
 case 3: /* BFMLAL{B,T} */
 gen_gvec_op4_fpst(s, 1, rd, rn, rm, rd, false, is_q,
   gen_helper_gvec_bfmlal);
@@ -12053,13 +12053,6 @@ static void disas_simd_indexed(DisasContext *s, 
uint32_t insn)
 break;
 case 0x0f:
 switch (size) {
-case 1: /* BFDOT */
-if (is_scalar || !dc_isar_feature(aa64_bf16, s)) {
-unallocated_encoding(s);
-return;
-}
-size = MO_32;
-break;
 case 3: /* BFMLAL{B,T} */
 if (is_scalar || !dc_isar_feature(aa64_bf16, s)) {
 unallocated_encoding(s);
@@ -12070,6 +12063,7 @@ static void disas_simd_indexed(DisasContext *s, 
uint32_t insn)
 break;
 default:
 case 0: /* SUDOT */
+case 1: /* BFDOT */
 case 2: /* USDOT */
 unallocated_encoding(s);
 return;
@@ -12179,10 +12173,6 @@ static void disas_simd_indexed(DisasContext *s, 
uint32_t insn)
 switch (16 * u + opcode) {
 case 0x0f:
 switch (extract32(insn, 22, 2)) {
-case 1: /* BFDOT */
-gen_gvec_op4_ool(s, is_q, rd, rn, rm, rd, index,
- gen_helper_gvec_bfdot_idx);
-return;
 case 3: /* BFMLAL{B,T} */
 gen_gvec_op4_fpst(s, 1, rd, rn, rm, rd, 0, (index << 1) | is_q,
   gen_helper_gvec_bfmlal_idx);
-- 
2.34.1