Re: [PATCH 08/43] migration: Move migrate_use_multifd() to options.c

2023-04-20 Thread Vladimir Sementsov-Ogievskiy

On 02.03.23 19:33, Juan Quintela wrote:

Once that we are there, we rename the function to migrate_multifd()
to be consistent with all other capabilities.

Signed-off-by: Juan Quintela


Reviewed-by: Vladimir Sementsov-Ogievskiy 

--
Best regards,
Vladimir




[PATCH 08/43] migration: Move migrate_use_multifd() to options.c

2023-03-02 Thread Juan Quintela
Once that we are there, we rename the function to migrate_multifd()
to be consistent with all other capabilities.

Signed-off-by: Juan Quintela 
---
 migration/migration.h |  1 -
 migration/options.h   |  1 +
 migration/migration.c | 19 +--
 migration/multifd.c   | 16 
 migration/options.c   |  9 +
 migration/ram.c   |  2 +-
 migration/socket.c|  2 +-
 7 files changed, 25 insertions(+), 25 deletions(-)

diff --git a/migration/migration.h b/migration/migration.h
index 9d0b1fa45b..19008fae0b 100644
--- a/migration/migration.h
+++ b/migration/migration.h
@@ -410,7 +410,6 @@ MigrationState *migrate_get_current(void);
 
 bool migrate_postcopy(void);
 
-bool migrate_use_multifd(void);
 int migrate_multifd_channels(void);
 MultiFDCompression migrate_multifd_compression(void);
 int migrate_multifd_zlib_level(void);
diff --git a/migration/options.h b/migration/options.h
index caf3b3aa69..a4f05a5e13 100644
--- a/migration/options.h
+++ b/migration/options.h
@@ -26,6 +26,7 @@ bool migrate_dirty_bitmaps(void);
 bool migrate_events(void);
 bool migrate_ignore_shared(void);
 bool migrate_late_block_activate(void);
+bool migrate_multifd(void);
 bool migrate_pause_before_switchover(void);
 bool migrate_postcopy_blocktime(void);
 bool migrate_postcopy_preempt(void);
diff --git a/migration/migration.c b/migration/migration.c
index 6c87aab8af..97daab9fd4 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -186,7 +186,7 @@ static void migrate_fd_cancel(MigrationState *s);
 
 static bool migration_needs_multiple_sockets(void)
 {
-return migrate_use_multifd() || migrate_postcopy_preempt();
+return migrate_multifd() || migrate_postcopy_preempt();
 }
 
 static bool uri_supports_multi_channels(const char *uri)
@@ -732,7 +732,7 @@ void migration_fd_process_incoming(QEMUFile *f, Error 
**errp)
 static bool migration_should_start_incoming(bool main_channel)
 {
 /* Multifd doesn't start unless all channels are established */
-if (migrate_use_multifd()) {
+if (migrate_multifd()) {
 return migration_has_all_channels();
 }
 
@@ -759,7 +759,7 @@ void migration_ioc_process_incoming(QIOChannel *ioc, Error 
**errp)
 uint32_t channel_magic = 0;
 int ret = 0;
 
-if (migrate_use_multifd() && !migrate_postcopy_ram() &&
+if (migrate_multifd() && !migrate_postcopy_ram() &&
 qio_channel_has_feature(ioc, QIO_CHANNEL_FEATURE_READ_MSG_PEEK)) {
 /*
  * With multiple channels, it is possible that we receive channels
@@ -798,7 +798,7 @@ void migration_ioc_process_incoming(QIOChannel *ioc, Error 
**errp)
 } else {
 /* Multiple connections */
 assert(migration_needs_multiple_sockets());
-if (migrate_use_multifd()) {
+if (migrate_multifd()) {
 multifd_recv_new_channel(ioc, _err);
 } else {
 assert(migrate_postcopy_preempt());
@@ -834,7 +834,7 @@ bool migration_has_all_channels(void)
 return false;
 }
 
-if (migrate_use_multifd()) {
+if (migrate_multifd()) {
 return multifd_recv_all_channels_created();
 }
 
@@ -2556,15 +2556,6 @@ int migrate_decompress_threads(void)
 return s->parameters.decompress_threads;
 }
 
-bool migrate_use_multifd(void)
-{
-MigrationState *s;
-
-s = migrate_get_current();
-
-return s->capabilities[MIGRATION_CAPABILITY_MULTIFD];
-}
-
 int migrate_multifd_channels(void)
 {
 MigrationState *s;
diff --git a/migration/multifd.c b/migration/multifd.c
index 91552d33bf..95127feb8b 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -516,7 +516,7 @@ void multifd_save_cleanup(void)
 {
 int i;
 
-if (!migrate_use_multifd()) {
+if (!migrate_multifd()) {
 return;
 }
 multifd_send_terminate_threads(NULL);
@@ -587,7 +587,7 @@ int multifd_send_sync_main(QEMUFile *f)
 int i;
 bool flush_zero_copy;
 
-if (!migrate_use_multifd()) {
+if (!migrate_multifd()) {
 return 0;
 }
 if (multifd_send_state->pages->num) {
@@ -910,7 +910,7 @@ int multifd_save_setup(Error **errp)
 uint32_t page_count = MULTIFD_PACKET_SIZE / qemu_target_page_size();
 uint8_t i;
 
-if (!migrate_use_multifd()) {
+if (!migrate_multifd()) {
 return 0;
 }
 
@@ -1015,7 +1015,7 @@ static void multifd_recv_terminate_threads(Error *err)
 
 void multifd_load_shutdown(void)
 {
-if (migrate_use_multifd()) {
+if (migrate_multifd()) {
 multifd_recv_terminate_threads(NULL);
 }
 }
@@ -1024,7 +1024,7 @@ void multifd_load_cleanup(void)
 {
 int i;
 
-if (!migrate_use_multifd()) {
+if (!migrate_multifd()) {
 return;
 }
 multifd_recv_terminate_threads(NULL);
@@ -1071,7 +1071,7 @@ void multifd_recv_sync_main(void)
 {
 int i;
 
-if (!migrate_use_multifd()) {
+if (!migrate_multifd()) {
 return;
 }
 for (i = 0; i < migrate_multifd_channels(); i++) {
@@ -1169,7 +1169,7 @@ int