Re: [PATCH 1/3] hw/nios2:fix leak of fdevice tree blob

[Laurent Vivier]

Le 18/02/2020 à 10:11, kuhn.chen...@huawei.com a écrit :
> From: Chen Qun 
> 
> The device tree blob returned by load_device_tree is malloced.
> We should free it after cpu_physical_memory_write().
> 
> Reported-by: Euler Robot 
> Signed-off-by: Chen Qun 
> ---
>  hw/nios2/boot.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/nios2/boot.c b/hw/nios2/boot.c
> index 46b8349876..88224aa84c 100644
> --- a/hw/nios2/boot.c
> +++ b/hw/nios2/boot.c
> @@ -109,6 +109,7 @@ static int nios2_load_dtb(struct nios2_boot_info bi, 
> const uint32_t ramsize,
>  }
>  
>  cpu_physical_memory_write(bi.fdt, fdt, fdt_size);
> +g_free(fdt);
>  return fdt_size;
>  }
>  
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

[PATCH 1/3] hw/nios2:fix leak of fdevice tree blob

[kuhn.chenqun]

From: Chen Qun 

The device tree blob returned by load_device_tree is malloced.
We should free it after cpu_physical_memory_write().

Reported-by: Euler Robot 
Signed-off-by: Chen Qun 
---
 hw/nios2/boot.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/nios2/boot.c b/hw/nios2/boot.c
index 46b8349876..88224aa84c 100644
--- a/hw/nios2/boot.c
+++ b/hw/nios2/boot.c
@@ -109,6 +109,7 @@ static int nios2_load_dtb(struct nios2_boot_info bi, const 
uint32_t ramsize,
 }
 
 cpu_physical_memory_write(bi.fdt, fdt, fdt_size);
+g_free(fdt);
 return fdt_size;
 }
 
-- 
2.23.0