Re: [PATCH 1/5] target/i386: SEV: rename sev_snp_guest->id_block

[Richard Henderson]

On 6/27/24 07:53, Paolo Bonzini wrote:

Free the "id_block" name for the binary version of the data.

Signed-off-by: Paolo Bonzini
---
  target/i386/sev.c | 12 ++--
  1 file changed, 6 insertions(+), 6 deletions(-)


Reviewed-by: Richard Henderson 

r~

[PATCH 1/5] target/i386: SEV: rename sev_snp_guest->id_block

[Paolo Bonzini]

Free the "id_block" name for the binary version of the data.

Signed-off-by: Paolo Bonzini 
---
 target/i386/sev.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/target/i386/sev.c b/target/i386/sev.c
index 30b83f1d77d..6daa8c264cd 100644
--- a/target/i386/sev.c
+++ b/target/i386/sev.c
@@ -152,7 +152,7 @@ struct SevSnpGuestState {
 
 /* configuration parameters */
 char *guest_visible_workarounds;
-char *id_block;
+char *id_block_base64;
 char *id_auth;
 char *host_data;
 
@@ -1296,7 +1296,7 @@ sev_snp_launch_finish(SevCommonState *sev_common)
 }
 }
 
-trace_kvm_sev_snp_launch_finish(sev_snp->id_block, sev_snp->id_auth,
+trace_kvm_sev_snp_launch_finish(sev_snp->id_block_base64, sev_snp->id_auth,
 sev_snp->host_data);
 ret = sev_ioctl(sev_common->sev_fd, KVM_SEV_SNP_LAUNCH_FINISH,
 finish, );
@@ -2159,7 +2159,7 @@ sev_snp_guest_get_id_block(Object *obj, Error **errp)
 {
 SevSnpGuestState *sev_snp_guest = SEV_SNP_GUEST(obj);
 
-return g_strdup(sev_snp_guest->id_block);
+return g_strdup(sev_snp_guest->id_block_base64);
 }
 
 static void
@@ -2170,14 +2170,14 @@ sev_snp_guest_set_id_block(Object *obj, const char 
*value, Error **errp)
 gsize len;
 
 finish->id_block_en = 0;
-g_free(sev_snp_guest->id_block);
+g_free(sev_snp_guest->id_block_base64);
 g_free((guchar *)finish->id_block_uaddr);
 
 /* store the base64 str so we don't need to re-encode in getter */
-sev_snp_guest->id_block = g_strdup(value);
+sev_snp_guest->id_block_base64 = g_strdup(value);
 
 finish->id_block_uaddr =
-(uint64_t)qbase64_decode(sev_snp_guest->id_block, -1, , errp);
+(uint64_t)qbase64_decode(sev_snp_guest->id_block_base64, -1, , 
errp);
 
 if (!finish->id_block_uaddr) {
 return;
-- 
2.45.2