Re: [PATCH 13/13] qom: Simplify object_property_get_enum()

2020-04-23 Thread Eric Blake 

On 4/23/20 11:00 AM, Markus Armbruster wrote:

Signed-off-by: Markus Armbruster 
---
  qom/object.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)



Reviewed-by: Eric Blake 

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

[PATCH 13/13] qom: Simplify object_property_get_enum()

2020-04-23 Thread Markus Armbruster 
Signed-off-by: Markus Armbruster 
---
 qom/object.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/qom/object.c b/qom/object.c
index 1812f79224..be700e831f 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -1550,11 +1550,9 @@ int object_property_get_enum(Object *obj, const char 
*name,
 }
 visit_complete(v, );
 visit_free(v);
-v = string_input_visitor_new(str);
-visit_type_enum(v, name, , enumprop->lookup, errp);
 
+ret = qapi_enum_parse(enumprop->lookup, str, -1, errp);
 g_free(str);
-visit_free(v);
 
 return ret;
 }
-- 
2.21.1