Re: [PATCH 14/19] plugins: fix -Werror=maybe-uninitialized false-positive

2024-03-28 Thread Pierrick Bouvier 

On 3/28/24 14:20, marcandre.lur...@redhat.com wrote:

From: Marc-André Lureau 

../plugins/loader.c:405:15: error: ‘ctx’ may be used uninitialized 
[-Werror=maybe-uninitialized]

Signed-off-by: Marc-André Lureau 
---
  plugins/loader.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/loader.c b/plugins/loader.c
index 9768b78eb6..513a429c57 100644
--- a/plugins/loader.c
+++ b/plugins/loader.c
@@ -390,7 +390,7 @@ void plugin_reset_uninstall(qemu_plugin_id_t id,
  bool reset)
  {
  struct qemu_plugin_reset_data *data;
-struct qemu_plugin_ctx *ctx;
+struct qemu_plugin_ctx *ctx = NULL;
  
  WITH_QEMU_LOCK_GUARD(&plugin.lock) {

  ctx = plugin_id_to_ctx_locked(id);


Reviewed-by: Pierrick Bouvier

[PATCH 14/19] plugins: fix -Werror=maybe-uninitialized false-positive

2024-03-28 Thread marcandre . lureau 
From: Marc-André Lureau 

../plugins/loader.c:405:15: error: ‘ctx’ may be used uninitialized 
[-Werror=maybe-uninitialized]

Signed-off-by: Marc-André Lureau 
---
 plugins/loader.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/loader.c b/plugins/loader.c
index 9768b78eb6..513a429c57 100644
--- a/plugins/loader.c
+++ b/plugins/loader.c
@@ -390,7 +390,7 @@ void plugin_reset_uninstall(qemu_plugin_id_t id,
 bool reset)
 {
 struct qemu_plugin_reset_data *data;
-struct qemu_plugin_ctx *ctx;
+struct qemu_plugin_ctx *ctx = NULL;
 
 WITH_QEMU_LOCK_GUARD(&plugin.lock) {
 ctx = plugin_id_to_ctx_locked(id);
-- 
2.44.0