Re: [PATCH 15/19] migration: fix -Werror=maybe-uninitialized false-positive

[Peter Xu]

On Thu, Mar 28, 2024 at 02:20:48PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau 
> 
> ../migration/ram.c:1873:23: error: ‘dirty’ may be used uninitialized 
> [-Werror=maybe-uninitialized]
> 
> When 'block' != NULL, 'dirty' is initialized.
> 
> Signed-off-by: Marc-André Lureau 

Acked-by: Peter Xu 

-- 
Peter Xu

[PATCH 15/19] migration: fix -Werror=maybe-uninitialized false-positive

[marcandre . lureau]

From: Marc-André Lureau 

../migration/ram.c:1873:23: error: ‘dirty’ may be used uninitialized 
[-Werror=maybe-uninitialized]

When 'block' != NULL, 'dirty' is initialized.

Signed-off-by: Marc-André Lureau 
---
 migration/ram.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/migration/ram.c b/migration/ram.c
index 8deb84984f..4e26bced31 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1847,7 +1847,7 @@ static bool get_queued_page(RAMState *rs, 
PageSearchStatus *pss)
 {
 RAMBlock  *block;
 ram_addr_t offset;
-bool dirty;
+bool dirty = false;
 
 do {
 block = unqueue_page(rs, &offset);
-- 
2.44.0