Re: [PATCH 2/2] tests/qtest/test-hmp: Fix migrate_set_parameter xbzrle-cache-size test

[Thomas Huth]

On 25/08/2023 17.59, Markus Armbruster wrote:

The command always fails with "Error: Parameter 'xbzrle_cache_size'
expects a power of two no less than the target page size".  The test
passes anyway.  Change the argument from 1 to 64k to make the test a
bit more useful.

Signed-off-by: Markus Armbruster 
---
  tests/qtest/test-hmp.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qtest/test-hmp.c b/tests/qtest/test-hmp.c
index c0d2d70689..fc9125f8bb 100644
--- a/tests/qtest/test-hmp.c
+++ b/tests/qtest/test-hmp.c
@@ -45,7 +45,7 @@ static const char *hmp_cmds[] = {
  "log all",
  "log none",
  "memsave 0 4096 \"/dev/null\"",
-"migrate_set_parameter xbzrle-cache-size 1",
+"migrate_set_parameter xbzrle-cache-size 64k",
  "migrate_set_parameter downtime-limit 1",
  "migrate_set_parameter max-bandwidth 1",
  "netdev_add user,id=net1",


Reviewed-by: Thomas Huth 

[PATCH 2/2] tests/qtest/test-hmp: Fix migrate_set_parameter xbzrle-cache-size test

[Markus Armbruster]

The command always fails with "Error: Parameter 'xbzrle_cache_size'
expects a power of two no less than the target page size".  The test
passes anyway.  Change the argument from 1 to 64k to make the test a
bit more useful.

Signed-off-by: Markus Armbruster 
---
 tests/qtest/test-hmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qtest/test-hmp.c b/tests/qtest/test-hmp.c
index c0d2d70689..fc9125f8bb 100644
--- a/tests/qtest/test-hmp.c
+++ b/tests/qtest/test-hmp.c
@@ -45,7 +45,7 @@ static const char *hmp_cmds[] = {
 "log all",
 "log none",
 "memsave 0 4096 \"/dev/null\"",
-"migrate_set_parameter xbzrle-cache-size 1",
+"migrate_set_parameter xbzrle-cache-size 64k",
 "migrate_set_parameter downtime-limit 1",
 "migrate_set_parameter max-bandwidth 1",
 "netdev_add user,id=net1",
-- 
2.41.0