Re: [PATCH 2/2] vdpa: Check for existence of opts.vhostdev

[Jason Wang]

On Sat, Nov 13, 2021 at 3:35 AM Eugenio Pérez  wrote:
>
> Since net_init_vhost_vdpa is trying to open it. Not specifying it in the
> command line crash qemu.
>
> Fixes: 7327813d17 ("vhost-vdpa: open device fd in net_init_vhost_vdpa()")
> Signed-off-by: Eugenio Pérez 

Acked-by: Jason Wang 

> ---
>  net/vhost-vdpa.c | 4 
>  1 file changed, 4 insertions(+)
>
> diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
> index 6ffb29f4da..bbd3576f23 100644
> --- a/net/vhost-vdpa.c
> +++ b/net/vhost-vdpa.c
> @@ -260,6 +260,10 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char 
> *name,
>
>  assert(netdev->type == NET_CLIENT_DRIVER_VHOST_VDPA);
>  opts = >u.vhost_vdpa;
> +if (!opts->vhostdev) {
> +error_setg(errp, "vdpa character device not specified with 
> vhostdev");
> +return -1;
> +}
>
>  vdpa_device_fd = qemu_open(opts->vhostdev, O_RDWR, errp);
>  if (vdpa_device_fd == -1) {
> --
> 2.27.0
>

[PATCH 2/2] vdpa: Check for existence of opts.vhostdev

[Eugenio Pérez]

Since net_init_vhost_vdpa is trying to open it. Not specifying it in the
command line crash qemu.

Fixes: 7327813d17 ("vhost-vdpa: open device fd in net_init_vhost_vdpa()")
Signed-off-by: Eugenio Pérez 
---
 net/vhost-vdpa.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 6ffb29f4da..bbd3576f23 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -260,6 +260,10 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char 
*name,
 
 assert(netdev->type == NET_CLIENT_DRIVER_VHOST_VDPA);
 opts = >u.vhost_vdpa;
+if (!opts->vhostdev) {
+error_setg(errp, "vdpa character device not specified with vhostdev");
+return -1;
+}
 
 vdpa_device_fd = qemu_open(opts->vhostdev, O_RDWR, errp);
 if (vdpa_device_fd == -1) {
-- 
2.27.0