Re: [PATCH 2/5] include/migration: mark vmstate_register() as a legacy function
Alex Bennée wrote: > Mention that QOM-ified devices already have support for registering > the description. > > Signed-off-by: Alex Bennée Reviewed-by: Juan Quintela I really remove that function in a future series (well, I substitute it with vmstate_register_id() and vmstate_register_any(), but the comment applies to the new versions also). Later, Juan.
Re: [PATCH 2/5] include/migration: mark vmstate_register() as a legacy function
On Mon, Jun 19, 2023 at 06:14:34PM +0100, Alex Bennée wrote: > Mention that QOM-ified devices already have support for registering > the description. > > Signed-off-by: Alex Bennée Acked-by: Peter Xu -- Peter Xu
Re: [PATCH 2/5] include/migration: mark vmstate_register() as a legacy function
On 6/19/23 19:14, Alex Bennée wrote: Mention that QOM-ified devices already have support for registering the description. Signed-off-by: Alex Bennée --- include/migration/vmstate.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson r~
Re: [PATCH 2/5] include/migration: mark vmstate_register() as a legacy function
On 19/6/23 19:14, Alex Bennée wrote: Mention that QOM-ified devices already have support for registering the description. Signed-off-by: Alex Bennée --- include/migration/vmstate.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé
[PATCH 2/5] include/migration: mark vmstate_register() as a legacy function
Mention that QOM-ified devices already have support for registering the description. Signed-off-by: Alex Bennée --- include/migration/vmstate.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 084f5e784a..35579b2c1f 100644 --- a/include/migration/vmstate.h +++ b/include/migration/vmstate.h @@ -1209,7 +1209,14 @@ int vmstate_register_with_alias_id(VMStateIf *obj, uint32_t instance_id, int required_for_version, Error **errp); -/* Returns: 0 on success, -1 on failure */ +/** + * vmstate_register() - legacy function to register state serialisation description + * + * New code shouldn't be using this function as QOM-ified devices have + * dc->vmsd to store the serialisation description. + * + * Returns: 0 on success, -1 on failure + */ static inline int vmstate_register(VMStateIf *obj, int instance_id, const VMStateDescription *vmsd, void *opaque) -- 2.39.2
