Re: [PATCH 3/3] migration: move the units of migrate parameters from milliseconds to ms.

2020-03-30 Thread Juan Quintela
Mao Zhongyi  wrote:
> Signed-off-by: Mao Zhongyi 
> Suggested-by: Dr. David Alan Gilbert 

Reviewed-by: Juan Quintela 

I don't really care one way or another.  But I agree that consistence is good.




[PATCH 3/3] migration: move the units of migrate parameters from milliseconds to ms.

2020-03-28 Thread Mao Zhongyi
Signed-off-by: Mao Zhongyi 
Suggested-by: Dr. David Alan Gilbert 
---
 migration/migration.c | 2 +-
 monitor/hmp-cmds.c| 8 
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/migration/migration.c b/migration/migration.c
index e0223f3b15..d014da388a 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1212,7 +1212,7 @@ static bool migrate_params_check(MigrationParameters 
*params, Error **errp)
 (params->downtime_limit > MAX_MIGRATE_DOWNTIME)) {
 error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
"downtime_limit",
-   "an integer in the range of 0 to 200 milliseconds");
+   "an integer in the range of 0 to 200 ms");
 return false;
 }
 
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index 63097ddcc8..c5de8af1ee 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -231,18 +231,18 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict)
 monitor_printf(mon, "\n");
 }
 
-monitor_printf(mon, "total time: %" PRIu64 " milliseconds\n",
+monitor_printf(mon, "total time: %" PRIu64 " ms\n",
info->total_time);
 if (info->has_expected_downtime) {
-monitor_printf(mon, "expected downtime: %" PRIu64 " 
milliseconds\n",
+monitor_printf(mon, "expected downtime: %" PRIu64 " ms\n",
info->expected_downtime);
 }
 if (info->has_downtime) {
-monitor_printf(mon, "downtime: %" PRIu64 " milliseconds\n",
+monitor_printf(mon, "downtime: %" PRIu64 " ms\n",
info->downtime);
 }
 if (info->has_setup_time) {
-monitor_printf(mon, "setup: %" PRIu64 " milliseconds\n",
+monitor_printf(mon, "setup: %" PRIu64 " ms\n",
info->setup_time);
 }
 }
-- 
2.17.1