Re: [PATCH 3/4] i386/cpu: Enable perfmon-v2 and RAS feature bits on EPYC-Genoa
On 6/13/24 02:11, Zhao Liu wrote: > On Wed, Jun 12, 2024 at 02:12:19PM -0500, Babu Moger wrote: >> Date: Wed, 12 Jun 2024 14:12:19 -0500 >> From: Babu Moger >> Subject: [PATCH 3/4] i386/cpu: Enable perfmon-v2 and RAS feature bits on >> EPYC-Genoa >> X-Mailer: git-send-email 2.34.1 >> >> Following feature bits are added on EPYC-Genoa-v2 model. >> >> perfmon-v2: Allows guests to make use of the PerfMonV2 features. > > nit s/Allows/Allow/ Sure. > >> SUCCOR: Software uncorrectable error containment and recovery capability. >> The processor supports software containment of uncorrectable >> errors >> through context synchronizing data poisoning and deferred error >> interrupts. >> >> McaOverflowRecov: MCA overflow recovery support. >> >> The feature details are available in APM listed below [1]. >> [1] AMD64 Architecture Programmer's Manual Volume 2: System Programming >> Publication # 24593 Revision 3.41. >> >> Signed-off-by: Babu Moger >> Link: https://bugzilla.kernel.org/show_bug.cgi?id=206537 >> --- >> target/i386/cpu.c | 15 +++ >> 1 file changed, 15 insertions(+) > > Reviewed-by: Zhao Liu > -- Thanks Babu Moger
Re: [PATCH 3/4] i386/cpu: Enable perfmon-v2 and RAS feature bits on EPYC-Genoa
On Wed, Jun 12, 2024 at 02:12:19PM -0500, Babu Moger wrote: > Date: Wed, 12 Jun 2024 14:12:19 -0500 > From: Babu Moger > Subject: [PATCH 3/4] i386/cpu: Enable perfmon-v2 and RAS feature bits on > EPYC-Genoa > X-Mailer: git-send-email 2.34.1 > > Following feature bits are added on EPYC-Genoa-v2 model. > > perfmon-v2: Allows guests to make use of the PerfMonV2 features. nit s/Allows/Allow/ > SUCCOR: Software uncorrectable error containment and recovery capability. > The processor supports software containment of uncorrectable > errors > through context synchronizing data poisoning and deferred error > interrupts. > > McaOverflowRecov: MCA overflow recovery support. > > The feature details are available in APM listed below [1]. > [1] AMD64 Architecture Programmer's Manual Volume 2: System Programming > Publication # 24593 Revision 3.41. > > Signed-off-by: Babu Moger > Link: https://bugzilla.kernel.org/show_bug.cgi?id=206537 > --- > target/i386/cpu.c | 15 +++ > 1 file changed, 15 insertions(+) Reviewed-by: Zhao Liu
[PATCH 3/4] i386/cpu: Enable perfmon-v2 and RAS feature bits on EPYC-Genoa
Following feature bits are added on EPYC-Genoa-v2 model.
perfmon-v2: Allows guests to make use of the PerfMonV2 features.
SUCCOR: Software uncorrectable error containment and recovery capability.
The processor supports software containment of uncorrectable errors
through context synchronizing data poisoning and deferred error
interrupts.
McaOverflowRecov: MCA overflow recovery support.
The feature details are available in APM listed below [1].
[1] AMD64 Architecture Programmer's Manual Volume 2: System Programming
Publication # 24593 Revision 3.41.
Signed-off-by: Babu Moger
Link: https://bugzilla.kernel.org/show_bug.cgi?id=206537
---
target/i386/cpu.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 7f1837cdc9..64e6dc62e2 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -5272,6 +5272,21 @@ static const X86CPUDefinition builtin_x86_defs[] = {
.xlevel = 0x8022,
.model_id = "AMD EPYC-Genoa Processor",
.cache_info = &epyc_genoa_cache_info,
+.versions = (X86CPUVersionDefinition[]) {
+{ .version = 1 },
+{
+.version = 2,
+.props = (PropValue[]) {
+{ "overflow-recov", "on" },
+{ "succor", "on" },
+{ "perfmon-v2", "on" },
+{ "model-id",
+ "AMD EPYC-Genoa-v2 Processor" },
+{ /* end of list */ }
+},
+},
+{ /* end of list */ }
+}
},
};
--
2.34.1
