Re: [PATCH 3/7] python/qemu: add README.rst

[John Snow]

On 6/5/20 10:56 AM, Vladimir Sementsov-Ogievskiy wrote:
> 03.06.2020 03:15, John Snow wrote:
>> Add a short readme that explains the package hierarchy, which will be
>> visible while browsing the source on e.g. gitlab/github.
>>
>> Signed-off-by: John Snow 
>> ---
>>   python/qemu/README.rst | 8 
>>   1 file changed, 8 insertions(+)
>>   create mode 100644 python/qemu/README.rst
>>
>> diff --git a/python/qemu/README.rst b/python/qemu/README.rst
>> new file mode 100644
>> index 000..96447b90616
>> --- /dev/null
>> +++ b/python/qemu/README.rst
>> @@ -0,0 +1,8 @@
>> +python/qemu/
>> +
>> +
>> +This directory serves as the root of a `Python PEP 420 implicit
>> +namespace package <`_.
>> +
>> +Each directory below is assumed to be an installable Python module that
> 
> As far as I understand terminology: s/module/package/
> 
>> +will be available under the ``qemu.`` namespace.
>>
> 
> and here.
> 
> Possibly I'm wrong. anyway:
> Reviewed-by: Vladimir Sementsov-Ogievskiy 
> 

Oh, you're right. Each file is a module, each folder is a package. Thank
you for spotting that.

Re: [PATCH 3/7] python/qemu: add README.rst

[Vladimir Sementsov-Ogievskiy]

03.06.2020 03:15, John Snow wrote:

Add a short readme that explains the package hierarchy, which will be
visible while browsing the source on e.g. gitlab/github.

Signed-off-by: John Snow 
---
  python/qemu/README.rst | 8 
  1 file changed, 8 insertions(+)
  create mode 100644 python/qemu/README.rst

diff --git a/python/qemu/README.rst b/python/qemu/README.rst
new file mode 100644
index 000..96447b90616
--- /dev/null
+++ b/python/qemu/README.rst
@@ -0,0 +1,8 @@
+python/qemu/
+
+
+This directory serves as the root of a `Python PEP 420 implicit
+namespace package <`_.
+
+Each directory below is assumed to be an installable Python module that


As far as I understand terminology: s/module/package/


+will be available under the ``qemu.`` namespace.



and here.

Possibly I'm wrong. anyway:
Reviewed-by: Vladimir Sementsov-Ogievskiy 

--
Best regards,
Vladimir

[PATCH 3/7] python/qemu: add README.rst

[John Snow]

Add a short readme that explains the package hierarchy, which will be
visible while browsing the source on e.g. gitlab/github.

Signed-off-by: John Snow 
---
 python/qemu/README.rst | 8 
 1 file changed, 8 insertions(+)
 create mode 100644 python/qemu/README.rst

diff --git a/python/qemu/README.rst b/python/qemu/README.rst
new file mode 100644
index 000..96447b90616
--- /dev/null
+++ b/python/qemu/README.rst
@@ -0,0 +1,8 @@
+python/qemu/
+
+
+This directory serves as the root of a `Python PEP 420 implicit
+namespace package <`_.
+
+Each directory below is assumed to be an installable Python module that
+will be available under the ``qemu.`` namespace.
-- 
2.21.3