Re: [PATCH 4/3] gitlab-ci: Don't try to use the system libfdt in the debian job
On 8/27/21 5:17 PM, Thomas Huth wrote: > libfdt in Debian is too old to be usable for QEMU. So far we were > silently falling back to the internal dtc submodule, but since > this is wrong, let's remove the --enable-fdt=system switch here now. > > Signed-off-by: Thomas Huth > --- > Sorry, I just noticed this after sending out the first three patches already > > .gitlab-ci.d/buildtest.yml | 1 - > 1 file changed, 1 deletion(-) Acked-by: Philippe Mathieu-Daudé
Re: [PATCH 4/3] gitlab-ci: Don't try to use the system libfdt in the debian job
On Fri, Aug 27, 2021 at 05:17:18PM +0200, Thomas Huth wrote: > libfdt in Debian is too old to be usable for QEMU. So far we were > silently falling back to the internal dtc submodule, but since > this is wrong, let's remove the --enable-fdt=system switch here now. > > Signed-off-by: Thomas Huth > --- > Sorry, I just noticed this after sending out the first three patches already > > .gitlab-ci.d/buildtest.yml | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
[PATCH 4/3] gitlab-ci: Don't try to use the system libfdt in the debian job
libfdt in Debian is too old to be usable for QEMU. So far we were silently falling back to the internal dtc submodule, but since this is wrong, let's remove the --enable-fdt=system switch here now. Signed-off-by: Thomas Huth --- Sorry, I just noticed this after sending out the first three patches already .gitlab-ci.d/buildtest.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index 903ee65f32..f0eb5f6286 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -74,7 +74,6 @@ build-system-debian: job: amd64-debian-container variables: IMAGE: debian-amd64 -CONFIGURE_ARGS: --enable-fdt=system TARGETS: arm-softmmu avr-softmmu i386-softmmu mipsel-softmmu riscv64-softmmu sh4eb-softmmu sparc-softmmu xtensaeb-softmmu MAKE_CHECK_ARGS: check-build -- 2.27.0
[PATCH 4/3] gitlab-ci: Don't try to use the system libfdt in the debian job
libfdt in Debian is too old to be usable for QEMU. So far we were silently falling back to the internal dtc submodule, but since this is wrong, let's remove the --enable-fdt=system switch here now. Signed-off-by: Thomas Huth --- Sorry, I just noticed this after sending out the first three patches already .gitlab-ci.d/buildtest.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index 903ee65f32..f0eb5f6286 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -74,7 +74,6 @@ build-system-debian: job: amd64-debian-container variables: IMAGE: debian-amd64 -CONFIGURE_ARGS: --enable-fdt=system TARGETS: arm-softmmu avr-softmmu i386-softmmu mipsel-softmmu riscv64-softmmu sh4eb-softmmu sparc-softmmu xtensaeb-softmmu MAKE_CHECK_ARGS: check-build -- 2.27.0
