Re: [PATCH 4/4] tests/acpi: virt: update ACPI MADT and FADT binaries

2022-10-11 Thread Ani Sinha 



On Tue, 11 Oct 2022, Miguel Luis wrote:

> Step 6 & 7 of the bios-tables-test.c documented procedure.
>
> Differences between disassembled ASL files for MADT:
>
> @@ -11,9 +11,9 @@
>   */
>
>  [000h    4]Signature : "APIC"[Multiple APIC 
> Description Table (MADT)]
> -[004h 0004   4] Table Length : 00A8
> -[008h 0008   1] Revision : 03
> -[009h 0009   1] Checksum : 50
> +[004h 0004   4] Table Length : 00AC
> +[008h 0008   1] Revision : 04
> +[009h 0009   1] Checksum : 47
>  [00Ah 0010   6]   Oem ID : "BOCHS "
>  [010h 0016   8] Oem Table ID : "BXPC"
>  [018h 0024   4] Oem Revision : 0001
> @@ -34,7 +34,7 @@
>  [041h 0065   3] Reserved : 00
>
>  [044h 0068   1]Subtable Type : 0B [Generic Interrupt 
> Controller]
> -[045h 0069   1]   Length : 4C
> +[045h 0069   1]   Length : 50
>  [046h 0070   2] Reserved : 
>  [048h 0072   4] CPU Interface Number : 
>  [04Ch 0076   4]Processor UID : 
> @@ -51,28 +51,29 @@
>  [07Ch 0124   4]Virtual GIC Interrupt : 
>  [080h 0128   8]   Redistributor Base Address : 
>  [088h 0136   8]ARM MPIDR : 
> -/ ACPI subtable terminates early - may be older version (dump table) */
> +[090h 0144   1] Efficiency Class : 00
> +[091h 0145   3] Reserved : 00
>
> -[090h 0144   1]Subtable Type : 0D [Generic MSI Frame]
> -[091h 0145   1]   Length : 18
> -[092h 0146   2] Reserved : 
> -[094h 0148   4] MSI Frame ID : 
> -[098h 0152   8] Base Address : 0802
> -[0A0h 0160   4]Flags (decoded below) : 0001
> +[094h 0148   1]Subtable Type : 0D [Generic MSI Frame]
> +[095h 0149   1]   Length : 18
> +[096h 0150   2] Reserved : 
> +[098h 0152   4] MSI Frame ID : 
> +[09Ch 0156   8] Base Address : 0802
> +[0A4h 0164   4]Flags (decoded below) : 0001
>Select SPI : 1
> -[0A4h 0164   2]SPI Count : 0040
> -[0A6h 0166   2] SPI Base : 0050
> +[0A8h 0168   2]SPI Count : 0040
> +[0AAh 0170   2] SPI Base : 0050
>
> -Raw Table Data: Length 168 (0xA8)
> +Raw Table Data: Length 172 (0xAC)
>
> -: 41 50 49 43 A8 00 00 00 03 50 42 4F 43 48 53 20  // APIC.PBOCHS
> +: 41 50 49 43 AC 00 00 00 04 47 42 4F 43 48 53 20  // APIC.GBOCHS
>  0010: 42 58 50 43 20 20 20 20 01 00 00 00 42 58 50 43  // BXPC
> BXPC
>  0020: 01 00 00 00 00 00 00 00 00 00 00 00 0C 18 00 00  // 
> 
>  0030: 00 00 00 00 00 00 00 08 00 00 00 00 00 00 00 00  // 
> 
> -0040: 02 00 00 00 0B 4C 00 00 00 00 00 00 00 00 00 00  // 
> .L..
> +0040: 02 00 00 00 0B 50 00 00 00 00 00 00 00 00 00 00  // 
> .P..
>  0050: 01 00 00 00 00 00 00 00 17 00 00 00 00 00 00 00  // 
> 
>  0060: 00 00 00 00 00 00 01 08 00 00 00 00 00 00 04 08  // 
> 
>  0070: 00 00 00 00 00 00 03 08 00 00 00 00 00 00 00 00  // 
> 
>  0080: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  // 
> 
> -0090: 0D 18 00 00 00 00 00 00 00 00 02 08 00 00 00 00  // 
> 
> -00A0: 01 00 00 00 40 00 50 00  // @.P.
> +0090: 00 00 00 00 0D 18 00 00 00 00 00 00 00 00 02 08  // 
> 
> +00A0: 00 00 00 00 01 00 00 00 40 00 50 00  // @.P.
>
> Differences between disassembled ASL files for FADT:
>
> @@ -11,9 +11,9 @@
>   */
>
>  [000h    4]Signature : "FACP"[Fixed ACPI 
> Description Table (FADT)]
> -[004h 0004   4] Table Length : 010C
> -[008h 0008   1] Revision : 05
> -[009h 0009   1] Checksum : 55
> +[004h 0004   4] Table Length : 0114
> +[008h 0008   1] Revision : 06
> +[009h 0009   1] Checksum : 15
>  [00Ah 0010   6]   Oem ID : "BOCHS "
>  [010h 0016   8] Oem Table ID : "BXPC"
>  [018h 0024   4] Oem Revision : 0001
> @@ -99,7 +99,7 @@
>PSCI Compliant : 1
> Must use HVC for PSCI : 1
>
> -[083h 0131   1]  FADT Minor Revision : 01
> +[083h 0131   1]  FADT Minor Revision : 00
>  [084h 0132   8] FACS Address : 
>  [08Ch 0140

[PATCH 4/4] tests/acpi: virt: update ACPI MADT and FADT binaries

2022-10-11 Thread Miguel Luis 
Step 6 & 7 of the bios-tables-test.c documented procedure.

Differences between disassembled ASL files for MADT:

@@ -11,9 +11,9 @@
  */

 [000h    4]Signature : "APIC"[Multiple APIC 
Description Table (MADT)]
-[004h 0004   4] Table Length : 00A8
-[008h 0008   1] Revision : 03
-[009h 0009   1] Checksum : 50
+[004h 0004   4] Table Length : 00AC
+[008h 0008   1] Revision : 04
+[009h 0009   1] Checksum : 47
 [00Ah 0010   6]   Oem ID : "BOCHS "
 [010h 0016   8] Oem Table ID : "BXPC"
 [018h 0024   4] Oem Revision : 0001
@@ -34,7 +34,7 @@
 [041h 0065   3] Reserved : 00

 [044h 0068   1]Subtable Type : 0B [Generic Interrupt 
Controller]
-[045h 0069   1]   Length : 4C
+[045h 0069   1]   Length : 50
 [046h 0070   2] Reserved : 
 [048h 0072   4] CPU Interface Number : 
 [04Ch 0076   4]Processor UID : 
@@ -51,28 +51,29 @@
 [07Ch 0124   4]Virtual GIC Interrupt : 
 [080h 0128   8]   Redistributor Base Address : 
 [088h 0136   8]ARM MPIDR : 
-/ ACPI subtable terminates early - may be older version (dump table) */
+[090h 0144   1] Efficiency Class : 00
+[091h 0145   3] Reserved : 00

-[090h 0144   1]Subtable Type : 0D [Generic MSI Frame]
-[091h 0145   1]   Length : 18
-[092h 0146   2] Reserved : 
-[094h 0148   4] MSI Frame ID : 
-[098h 0152   8] Base Address : 0802
-[0A0h 0160   4]Flags (decoded below) : 0001
+[094h 0148   1]Subtable Type : 0D [Generic MSI Frame]
+[095h 0149   1]   Length : 18
+[096h 0150   2] Reserved : 
+[098h 0152   4] MSI Frame ID : 
+[09Ch 0156   8] Base Address : 0802
+[0A4h 0164   4]Flags (decoded below) : 0001
   Select SPI : 1
-[0A4h 0164   2]SPI Count : 0040
-[0A6h 0166   2] SPI Base : 0050
+[0A8h 0168   2]SPI Count : 0040
+[0AAh 0170   2] SPI Base : 0050

-Raw Table Data: Length 168 (0xA8)
+Raw Table Data: Length 172 (0xAC)

-: 41 50 49 43 A8 00 00 00 03 50 42 4F 43 48 53 20  // APIC.PBOCHS
+: 41 50 49 43 AC 00 00 00 04 47 42 4F 43 48 53 20  // APIC.GBOCHS
 0010: 42 58 50 43 20 20 20 20 01 00 00 00 42 58 50 43  // BXPCBXPC
 0020: 01 00 00 00 00 00 00 00 00 00 00 00 0C 18 00 00  // 
 0030: 00 00 00 00 00 00 00 08 00 00 00 00 00 00 00 00  // 
-0040: 02 00 00 00 0B 4C 00 00 00 00 00 00 00 00 00 00  // .L..
+0040: 02 00 00 00 0B 50 00 00 00 00 00 00 00 00 00 00  // .P..
 0050: 01 00 00 00 00 00 00 00 17 00 00 00 00 00 00 00  // 
 0060: 00 00 00 00 00 00 01 08 00 00 00 00 00 00 04 08  // 
 0070: 00 00 00 00 00 00 03 08 00 00 00 00 00 00 00 00  // 
 0080: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  // 
-0090: 0D 18 00 00 00 00 00 00 00 00 02 08 00 00 00 00  // 
-00A0: 01 00 00 00 40 00 50 00  // @.P.
+0090: 00 00 00 00 0D 18 00 00 00 00 00 00 00 00 02 08  // 
+00A0: 00 00 00 00 01 00 00 00 40 00 50 00  // @.P.

Differences between disassembled ASL files for FADT:

@@ -11,9 +11,9 @@
  */

 [000h    4]Signature : "FACP"[Fixed ACPI 
Description Table (FADT)]
-[004h 0004   4] Table Length : 010C
-[008h 0008   1] Revision : 05
-[009h 0009   1] Checksum : 55
+[004h 0004   4] Table Length : 0114
+[008h 0008   1] Revision : 06
+[009h 0009   1] Checksum : 15
 [00Ah 0010   6]   Oem ID : "BOCHS "
 [010h 0016   8] Oem Table ID : "BXPC"
 [018h 0024   4] Oem Revision : 0001
@@ -99,7 +99,7 @@
   PSCI Compliant : 1
Must use HVC for PSCI : 1

-[083h 0131   1]  FADT Minor Revision : 01
+[083h 0131   1]  FADT Minor Revision : 00
 [084h 0132   8] FACS Address : 
 [08Ch 0140   8] DSDT Address : 
 [094h 0148  12] PM1A Event Block : [Generic Address Structure]
@@ -173,11 +173,11 @@
 [103h 0259   1] Encoded Access Width : 00 [Undefined/Legacy]
 [104h 0260   8]  A