Re: [PATCH 8/8] Turn on CPU hot-(un)plug customization for loongarch
Hi, Igor Mammedov: On 7/28/23 9:30 PM, Igor Mammedov wrote: On Thu, 20 Jul 2023 15:15:13 +0800 xianglai li wrote: Turn on CPU hot-(un)plug custom for loongarch in the configuration file Cc: Xiaojuan Yang Cc: Song Gao Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Cc: Ani Sinha Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: Marcel Apfelbaum Cc: "Philippe Mathieu-Daudé" Cc: Yanan Wang Cc: "Daniel P. Berrangé" Cc: Peter Xu Cc: David Hildenbrand Signed-off-by: xianglai li --- configs/devices/loongarch64-softmmu/default.mak | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/devices/loongarch64-softmmu/default.mak b/configs/devices/loongarch64-softmmu/default.mak index 928bc117ef..e596706fab 100644 --- a/configs/devices/loongarch64-softmmu/default.mak +++ b/configs/devices/loongarch64-softmmu/default.mak @@ -1,3 +1,4 @@ # Default configuration for loongarch64-softmmu CONFIG_LOONGARCH_VIRT=y +CONFIG_ACPI_CPU_HOTPLUG=y this likely shall be part of prior patch (one that starts to use generic cpu hotplug functions) otherwise you risk a broke bisection in the middle of series (aka try to build series after applying each patch) Do you mean this patch should be inside the first patch? Thanks, xianglai
Re: [PATCH 8/8] Turn on CPU hot-(un)plug customization for loongarch
On Thu, 20 Jul 2023 15:15:13 +0800 xianglai li wrote: > Turn on CPU hot-(un)plug custom for loongarch in the configuration file > > Cc: Xiaojuan Yang > Cc: Song Gao > Cc: "Michael S. Tsirkin" > Cc: Igor Mammedov > Cc: Ani Sinha > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost > Cc: Marcel Apfelbaum > Cc: "Philippe Mathieu-Daudé" > Cc: Yanan Wang > Cc: "Daniel P. Berrangé" > Cc: Peter Xu > Cc: David Hildenbrand > Signed-off-by: xianglai li > --- > configs/devices/loongarch64-softmmu/default.mak | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configs/devices/loongarch64-softmmu/default.mak > b/configs/devices/loongarch64-softmmu/default.mak > index 928bc117ef..e596706fab 100644 > --- a/configs/devices/loongarch64-softmmu/default.mak > +++ b/configs/devices/loongarch64-softmmu/default.mak > @@ -1,3 +1,4 @@ > # Default configuration for loongarch64-softmmu > > CONFIG_LOONGARCH_VIRT=y > +CONFIG_ACPI_CPU_HOTPLUG=y this likely shall be part of prior patch (one that starts to use generic cpu hotplug functions) otherwise you risk a broke bisection in the middle of series (aka try to build series after applying each patch)
[PATCH 8/8] Turn on CPU hot-(un)plug customization for loongarch
Turn on CPU hot-(un)plug custom for loongarch in the configuration file Cc: Xiaojuan Yang Cc: Song Gao Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Cc: Ani Sinha Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: Marcel Apfelbaum Cc: "Philippe Mathieu-Daudé" Cc: Yanan Wang Cc: "Daniel P. Berrangé" Cc: Peter Xu Cc: David Hildenbrand Signed-off-by: xianglai li --- configs/devices/loongarch64-softmmu/default.mak | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/devices/loongarch64-softmmu/default.mak b/configs/devices/loongarch64-softmmu/default.mak index 928bc117ef..e596706fab 100644 --- a/configs/devices/loongarch64-softmmu/default.mak +++ b/configs/devices/loongarch64-softmmu/default.mak @@ -1,3 +1,4 @@ # Default configuration for loongarch64-softmmu CONFIG_LOONGARCH_VIRT=y +CONFIG_ACPI_CPU_HOTPLUG=y -- 2.39.1
