Re: [PATCH RESEND 2/4] migration/rdma: Fix rdma_addrinfo res leaks

2021-05-24 Thread Dr. David Alan Gilbert
* Li Zhijian (lizhij...@cn.fujitsu.com) wrote:
> rdma_freeaddrinfo() is the reverse operation of rdma_getaddrinfo()
> 
> Signed-off-by: Li Zhijian 

Reviewed-by: Dr. David Alan Gilbert 

That call seems entirely undocumented, but looks like it's been there at
least 10 years.

> ---
>  migration/rdma.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/migration/rdma.c b/migration/rdma.c
> index 7e7595faab..651534e825 100644
> --- a/migration/rdma.c
> +++ b/migration/rdma.c
> @@ -987,10 +987,12 @@ static int qemu_rdma_resolve_host(RDMAContext *rdma, 
> Error **errp)
>  }
>  }
>  
> +rdma_freeaddrinfo(res);
>  ERROR(errp, "could not resolve address %s", rdma->host);
>  goto err_resolve_get_addr;
>  
>  route:
> +rdma_freeaddrinfo(res);
>  qemu_rdma_dump_gid("source_resolve_addr", rdma->cm_id);
>  
>  ret = rdma_get_cm_event(rdma->channel, &cm_event);
> @@ -2593,6 +2595,7 @@ static int qemu_rdma_dest_init(RDMAContext *rdma, Error 
> **errp)
>  break;
>  }
>  
> +rdma_freeaddrinfo(res);
>  if (!e) {
>  ERROR(errp, "Error: could not rdma_bind_addr!");
>  goto err_dest_init_bind_addr;
> -- 
> 2.30.2
> 
> 
> 
-- 
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK




[PATCH RESEND 2/4] migration/rdma: Fix rdma_addrinfo res leaks

2021-05-20 Thread Li Zhijian
rdma_freeaddrinfo() is the reverse operation of rdma_getaddrinfo()

Signed-off-by: Li Zhijian 
---
 migration/rdma.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/migration/rdma.c b/migration/rdma.c
index 7e7595faab..651534e825 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -987,10 +987,12 @@ static int qemu_rdma_resolve_host(RDMAContext *rdma, 
Error **errp)
 }
 }
 
+rdma_freeaddrinfo(res);
 ERROR(errp, "could not resolve address %s", rdma->host);
 goto err_resolve_get_addr;
 
 route:
+rdma_freeaddrinfo(res);
 qemu_rdma_dump_gid("source_resolve_addr", rdma->cm_id);
 
 ret = rdma_get_cm_event(rdma->channel, &cm_event);
@@ -2593,6 +2595,7 @@ static int qemu_rdma_dest_init(RDMAContext *rdma, Error 
**errp)
 break;
 }
 
+rdma_freeaddrinfo(res);
 if (!e) {
 ERROR(errp, "Error: could not rdma_bind_addr!");
 goto err_dest_init_bind_addr;
-- 
2.30.2