Re: [PATCH for-5.1 0/3] target/arm: mte+pauth fixes
On Fri, 24 Jul 2020 at 17:38, Richard Henderson wrote: > > A couple of last minute fixes for MTE: > > (1) Peter pointed out that EL3's SCR.ATA needs to be set when > we're booting a kernel directly. Similarly for API & APK. > > (2) Vincenzo pointed out that with RRND=1, we can't rely on > RGSR having being initialized. > > I suppose the only follow-on question here is whether it is > better to minimize the number of calls to qemu_guest_getrandom, > or instead to name that our IMPDEF algorithm and use it for > every call to IRG. We already have other user-space available > RNG instructions that can drain the entropy pool, so this is > not really different. > Applied to target-arm.next, thanks. -- PMM
[PATCH for-5.1 0/3] target/arm: mte+pauth fixes
A couple of last minute fixes for MTE: (1) Peter pointed out that EL3's SCR.ATA needs to be set when we're booting a kernel directly. Similarly for API & APK. (2) Vincenzo pointed out that with RRND=1, we can't rely on RGSR having being initialized. I suppose the only follow-on question here is whether it is better to minimize the number of calls to qemu_guest_getrandom, or instead to name that our IMPDEF algorithm and use it for every call to IRG. We already have other user-space available RNG instructions that can drain the entropy pool, so this is not really different. r~ Richard Henderson (3): hw/arm/boot: Fix PAUTH for EL3 direct kernel boot hw/arm/boot: Fix MTE for EL3 direct kernel boot target/arm: Improve IMPDEF algorithm for IRG hw/arm/boot.c | 6 ++ target/arm/mte_helper.c | 37 ++--- 2 files changed, 36 insertions(+), 7 deletions(-) -- 2.25.1
