Re: [PATCH v12 6/6] target/riscv: Remove additional priv version check for mcountinhibit

[Alistair Francis]

On Wed, Aug 3, 2022 at 9:34 AM Atish Patra  wrote:
>
> With .min_priv_version, additiona priv version check is uncessary
> for mcountinhibit read/write functions.
>
> Reviewed-by: Heiko Stuebner 
> Tested-by: Heiko Stuebner 
> Signed-off-by: Atish Patra 

Reviewed-by: Alistair Francis 

Alistair

> ---
>  target/riscv/csr.c | 8 
>  1 file changed, 8 deletions(-)
>
> diff --git a/target/riscv/csr.c b/target/riscv/csr.c
> index 8753280e95b2..67367e678f38 100644
> --- a/target/riscv/csr.c
> +++ b/target/riscv/csr.c
> @@ -1489,10 +1489,6 @@ static RISCVException write_mtvec(CPURISCVState *env, 
> int csrno,
>  static RISCVException read_mcountinhibit(CPURISCVState *env, int csrno,
>   target_ulong *val)
>  {
> -if (env->priv_ver < PRIV_VERSION_1_11_0) {
> -return RISCV_EXCP_ILLEGAL_INST;
> -}
> -
>  *val = env->mcountinhibit;
>  return RISCV_EXCP_NONE;
>  }
> @@ -1503,10 +1499,6 @@ static RISCVException 
> write_mcountinhibit(CPURISCVState *env, int csrno,
>  int cidx;
>  PMUCTRState *counter;
>
> -if (env->priv_ver < PRIV_VERSION_1_11_0) {
> -return RISCV_EXCP_ILLEGAL_INST;
> -}
> -
>  env->mcountinhibit = val;
>
>  /* Check if any other counter is also monitoring cycles/instructions */
> --
> 2.25.1
>
>

[PATCH v12 6/6] target/riscv: Remove additional priv version check for mcountinhibit

[Atish Patra]

With .min_priv_version, additiona priv version check is uncessary
for mcountinhibit read/write functions.

Reviewed-by: Heiko Stuebner 
Tested-by: Heiko Stuebner 
Signed-off-by: Atish Patra 
---
 target/riscv/csr.c | 8 
 1 file changed, 8 deletions(-)

diff --git a/target/riscv/csr.c b/target/riscv/csr.c
index 8753280e95b2..67367e678f38 100644
--- a/target/riscv/csr.c
+++ b/target/riscv/csr.c
@@ -1489,10 +1489,6 @@ static RISCVException write_mtvec(CPURISCVState *env, 
int csrno,
 static RISCVException read_mcountinhibit(CPURISCVState *env, int csrno,
  target_ulong *val)
 {
-if (env->priv_ver < PRIV_VERSION_1_11_0) {
-return RISCV_EXCP_ILLEGAL_INST;
-}
-
 *val = env->mcountinhibit;
 return RISCV_EXCP_NONE;
 }
@@ -1503,10 +1499,6 @@ static RISCVException write_mcountinhibit(CPURISCVState 
*env, int csrno,
 int cidx;
 PMUCTRState *counter;
 
-if (env->priv_ver < PRIV_VERSION_1_11_0) {
-return RISCV_EXCP_ILLEGAL_INST;
-}
-
 env->mcountinhibit = val;
 
 /* Check if any other counter is also monitoring cycles/instructions */
-- 
2.25.1