Re: [PATCH v2] arm/translate-a64: fix uninitialized variable warning

2020-01-08 Thread Laurent Vivier 
Le 08/01/2020 à 03:39, pannengy...@huawei.com a écrit :
> From: Pan Nengyuan 
> 
> Fixes:
> target/arm/translate-a64.c: In function 'disas_crypto_three_reg_sha512':
> target/arm/translate-a64.c:13625:9: error: 'genfn' may be used uninitialized 
> in this function [-Werror=maybe-uninitialized]
> genfn(tcg_rd_ptr, tcg_rn_ptr, tcg_rm_ptr);
> ^
> qemu/target/arm/translate-a64.c:13609:8: error: 'feature' may be used 
> uninitialized in this function [-Werror=maybe-uninitialized]
> if (!feature) {
> 
> Reported-by: Euler Robot 
> Signed-off-by: Pan Nengyuan 
> ---
> Changes v2 to v1:
> - add a default label to fix uninitialized warnings(suggested by Richard 
> Henderson)
> ---
>  target/arm/translate-a64.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
> index d4bebbe629..63a3d26687 100644
> --- a/target/arm/translate-a64.c
> +++ b/target/arm/translate-a64.c
> @@ -13585,6 +13585,8 @@ static void 
> disas_crypto_three_reg_sha512(DisasContext *s, uint32_t insn)
>  feature = dc_isar_feature(aa64_sha3, s);
>  genfn = NULL;
>  break;
> +default:
> +g_assert_not_reached();
>  }
>  } else {
>  switch (opcode) {
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

Re: [PATCH v2] arm/translate-a64: fix uninitialized variable warning

2020-01-08 Thread Philippe Mathieu-Daudé 

On 1/8/20 3:39 AM, pannengy...@huawei.com wrote:

From: Pan Nengyuan 

Fixes:
target/arm/translate-a64.c: In function 'disas_crypto_three_reg_sha512':
target/arm/translate-a64.c:13625:9: error: 'genfn' may be used uninitialized in 
this function [-Werror=maybe-uninitialized]
 genfn(tcg_rd_ptr, tcg_rn_ptr, tcg_rm_ptr);
 ^
qemu/target/arm/translate-a64.c:13609:8: error: 'feature' may be used 
uninitialized in this function [-Werror=maybe-uninitialized]
 if (!feature) {

Reported-by: Euler Robot 
Signed-off-by: Pan Nengyuan 
---
Changes v2 to v1:
- add a default label to fix uninitialized warnings(suggested by Richard 
Henderson)
---
  target/arm/translate-a64.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index d4bebbe629..63a3d26687 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -13585,6 +13585,8 @@ static void disas_crypto_three_reg_sha512(DisasContext 
*s, uint32_t insn)
  feature = dc_isar_feature(aa64_sha3, s);
  genfn = NULL;
  break;
+default:
+g_assert_not_reached();
  }
  } else {
  switch (opcode) {



Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2] arm/translate-a64: fix uninitialized variable warning

2020-01-07 Thread Richard Henderson 
On 1/8/20 12:39 PM, pannengy...@huawei.com wrote:
> From: Pan Nengyuan 
> 
> Fixes:
> target/arm/translate-a64.c: In function 'disas_crypto_three_reg_sha512':
> target/arm/translate-a64.c:13625:9: error: 'genfn' may be used uninitialized 
> in this function [-Werror=maybe-uninitialized]
> genfn(tcg_rd_ptr, tcg_rn_ptr, tcg_rm_ptr);
> ^
> qemu/target/arm/translate-a64.c:13609:8: error: 'feature' may be used 
> uninitialized in this function [-Werror=maybe-uninitialized]
> if (!feature) {
> 
> Reported-by: Euler Robot 
> Signed-off-by: Pan Nengyuan 
> ---
> Changes v2 to v1:
> - add a default label to fix uninitialized warnings(suggested by Richard 
> Henderson)
> ---
>  target/arm/translate-a64.c | 2 ++
>  1 file changed, 2 insertions(+)
Reviewed-by: Richard Henderson 

Given that you are using -O2, this should probably also be reported as a GCC 
bug.


r~

[PATCH v2] arm/translate-a64: fix uninitialized variable warning

2020-01-07 Thread pannengyuan 
From: Pan Nengyuan 

Fixes:
target/arm/translate-a64.c: In function 'disas_crypto_three_reg_sha512':
target/arm/translate-a64.c:13625:9: error: 'genfn' may be used uninitialized in 
this function [-Werror=maybe-uninitialized]
genfn(tcg_rd_ptr, tcg_rn_ptr, tcg_rm_ptr);
^
qemu/target/arm/translate-a64.c:13609:8: error: 'feature' may be used 
uninitialized in this function [-Werror=maybe-uninitialized]
if (!feature) {

Reported-by: Euler Robot 
Signed-off-by: Pan Nengyuan 
---
Changes v2 to v1:
- add a default label to fix uninitialized warnings(suggested by Richard 
Henderson)
---
 target/arm/translate-a64.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index d4bebbe629..63a3d26687 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -13585,6 +13585,8 @@ static void disas_crypto_three_reg_sha512(DisasContext 
*s, uint32_t insn)
 feature = dc_isar_feature(aa64_sha3, s);
 genfn = NULL;
 break;
+default:
+g_assert_not_reached();
 }
 } else {
 switch (opcode) {
-- 
2.21.0.windows.1