Re: [PATCH v2 0/2] elf2dmp: Fix minor Coverity nits
On Fri, 10 Sept 2021 at 18:08, Philippe Mathieu-Daudé wrote: > > This is a respin of Peter Maydell series, with slightly different > logic on the first patch. Quoting v1 cover [*]: > > Coverity complains about a couple of minor issues in elf2dmp: >* we weren't checking the return value from curl_easy_setopt() >* we might divide by zero if presented with a corrupt PDB file > > This patchseries fixes those. > > Viktor Prutyanov tested the patch but didn't provided a formal > Tested-by tag, so I haven't included it in the patches. > > [*] > https://lore.kernel.org/qemu-devel/20210901143910.17112-1-peter.mayd...@linaro.org/ > > Peter Maydell (2): > elf2dmp: Check curl_easy_setopt() return value > elf2dmp: Fail cleanly if PDB file specifies zero block_size Thanks for doing the respin; I'll take this via target-arm.next. -- PMM
[PATCH v2 0/2] elf2dmp: Fix minor Coverity nits
This is a respin of Peter Maydell series, with slightly different logic on the first patch. Quoting v1 cover [*]: Coverity complains about a couple of minor issues in elf2dmp: * we weren't checking the return value from curl_easy_setopt() * we might divide by zero if presented with a corrupt PDB file This patchseries fixes those. Viktor Prutyanov tested the patch but didn't provided a formal Tested-by tag, so I haven't included it in the patches. [*] https://lore.kernel.org/qemu-devel/20210901143910.17112-1-peter.mayd...@linaro.org/ Peter Maydell (2): elf2dmp: Check curl_easy_setopt() return value elf2dmp: Fail cleanly if PDB file specifies zero block_size contrib/elf2dmp/download.c | 22 ++ contrib/elf2dmp/pdb.c | 4 2 files changed, 14 insertions(+), 12 deletions(-) -- 2.31.1