Re: [PATCH v2 01/11] scsi-disk: add FORMAT UNIT command

2022-05-25 Thread Laurent Vivier

Le 24/04/2022 à 18:49, Mark Cave-Ayland a écrit :

When initialising a drive ready to install MacOS, Apple HD SC Setup first 
attempts
to format the drive. Add a simple FORMAT UNIT command which simply returns 
success
to allow the format to succeed.

Signed-off-by: Mark Cave-Ayland 
---
  hw/scsi/scsi-disk.c  | 4 
  hw/scsi/trace-events | 1 +
  2 files changed, 5 insertions(+)



Reviewed-by: Laurent Vivier 




[PATCH v2 01/11] scsi-disk: add FORMAT UNIT command

2022-04-24 Thread Mark Cave-Ayland
When initialising a drive ready to install MacOS, Apple HD SC Setup first 
attempts
to format the drive. Add a simple FORMAT UNIT command which simply returns 
success
to allow the format to succeed.

Signed-off-by: Mark Cave-Ayland 
---
 hw/scsi/scsi-disk.c  | 4 
 hw/scsi/trace-events | 1 +
 2 files changed, 5 insertions(+)

diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index 072686ed58..090679f3b5 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -2127,6 +2127,9 @@ static int32_t scsi_disk_emulate_command(SCSIRequest 
*req, uint8_t *buf)
 trace_scsi_disk_emulate_command_WRITE_SAME(
 req->cmd.buf[0] == WRITE_SAME_10 ? 10 : 16, r->req.cmd.xfer);
 break;
+case FORMAT_UNIT:
+trace_scsi_disk_emulate_command_FORMAT_UNIT(r->req.cmd.xfer);
+break;
 default:
 trace_scsi_disk_emulate_command_UNKNOWN(buf[0],
 scsi_command_name(buf[0]));
@@ -2533,6 +2536,7 @@ static const SCSIReqOps *const 
scsi_disk_reqops_dispatch[256] = {
 [VERIFY_10]   = &scsi_disk_emulate_reqops,
 [VERIFY_12]   = &scsi_disk_emulate_reqops,
 [VERIFY_16]   = &scsi_disk_emulate_reqops,
+[FORMAT_UNIT] = &scsi_disk_emulate_reqops,
 
 [READ_6]  = &scsi_disk_dma_reqops,
 [READ_10] = &scsi_disk_dma_reqops,
diff --git a/hw/scsi/trace-events b/hw/scsi/trace-events
index 20fb0dc162..e91b55a961 100644
--- a/hw/scsi/trace-events
+++ b/hw/scsi/trace-events
@@ -334,6 +334,7 @@ scsi_disk_emulate_command_UNMAP(size_t xfer) "Unmap (len 
%zd)"
 scsi_disk_emulate_command_VERIFY(int bytchk) "Verify (bytchk %d)"
 scsi_disk_emulate_command_WRITE_SAME(int cmd, size_t xfer) "WRITE SAME %d (len 
%zd)"
 scsi_disk_emulate_command_UNKNOWN(int cmd, const char *name) "Unknown SCSI 
command (0x%2.2x=%s)"
+scsi_disk_emulate_command_FORMAT_UNIT(size_t xfer) "Format Unit (len %zd)"
 scsi_disk_dma_command_READ(uint64_t lba, uint32_t len) "Read (sector %" PRId64 
", count %u)"
 scsi_disk_dma_command_WRITE(const char *cmd, uint64_t lba, int len) "Write 
%s(sector %" PRId64 ", count %u)"
 scsi_disk_new_request(uint32_t lun, uint32_t tag, const char *line) "Command: 
lun=%d tag=0x%x data=%s"
-- 
2.20.1