Re: [PATCH v2 03/13] block/file-posix: Remove redundant statement in raw_handle_perm_lock()

2020-02-26 Thread Kevin Wolf
Am 26.02.2020 um 09:46 hat kuhn.chen...@huawei.com geschrieben:
> From: Chen Qun 
> 
> Clang static code analyzer show warning:
>   block/file-posix.c:891:9: warning: Value stored to 'op' is never read
> op = RAW_PL_ABORT;
> ^
> 
> Reported-by: Euler Robot 
> Signed-off-by: Chen Qun 

Reviewed-by: Kevin Wolf 




[PATCH v2 03/13] block/file-posix: Remove redundant statement in raw_handle_perm_lock()

2020-02-26 Thread kuhn.chenqun
From: Chen Qun 

Clang static code analyzer show warning:
  block/file-posix.c:891:9: warning: Value stored to 'op' is never read
op = RAW_PL_ABORT;
^

Reported-by: Euler Robot 
Signed-off-by: Chen Qun 
---
Cc: Kevin Wolf 
Cc: Max Reitz 
---
 block/file-posix.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/block/file-posix.c b/block/file-posix.c
index 6345477112..0f77447a25 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -888,7 +888,6 @@ static int raw_handle_perm_lock(BlockDriverState *bs,
   "Is another process using the image [%s]?\n",
   bs->filename);
 }
-op = RAW_PL_ABORT;
 /* fall through to unlock bytes. */
 case RAW_PL_ABORT:
 raw_apply_lock_bytes(s, s->fd, s->perm, ~s->shared_perm,
-- 
2.23.0