Re: [PATCH v2 06/50] dino: move pci_setup_iommu() to dino_pcihost_init()

[Richard Henderson]

On 5/4/22 02:25, Mark Cave-Ayland wrote:

Signed-off-by: Mark Cave-Ayland
Acked-by: Helge Deller
---
  hw/hppa/dino.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)


Reviewed-by: Richard Henderson 

r~

[PATCH v2 06/50] dino: move pci_setup_iommu() to dino_pcihost_init()

[Mark Cave-Ayland]

Signed-off-by: Mark Cave-Ayland 
Acked-by: Helge Deller 
---
 hw/hppa/dino.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c
index 13b2210462..dcebb9f98f 100644
--- a/hw/hppa/dino.c
+++ b/hw/hppa/dino.c
@@ -556,7 +556,6 @@ PCIBus *dino_init(MemoryRegion *addr_space,
 memory_region_add_subregion(&s->bm, 0xfff0,
 &s->bm_cpu_alias);
 address_space_init(&s->bm_as, &s->bm, "pci-bm");
-pci_setup_iommu(b, dino_pcihost_set_iommu, s);
 
 *p_rtc_irq = qemu_allocate_irq(dino_set_timer_irq, s, 0);
 *p_ser_irq = qemu_allocate_irq(dino_set_serial_irq, s, 0);
@@ -605,6 +604,8 @@ static void dino_pcihost_init(Object *obj)
 g_free(name);
 }
 
+pci_setup_iommu(phb->bus, dino_pcihost_set_iommu, s);
+
 sysbus_init_mmio(sbd, &s->this_mem);
 }
 
-- 
2.20.1