Re: [PATCH v2 1/3] adb: Correct class size on TYPE_ADB_DEVICE

[Cédric Le Goater]

On 9/1/20 1:51 AM, David Gibson wrote:
> The TypeInfo incorrectly just lets the class size be inherited.  It won't
> actually break things, since the class is abstract, but we should get it
> right.
> 
> Signed-off-by: David Gibson 

Reviewed-by: Cédric Le Goater 

> ---
>  hw/input/adb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/input/adb.c b/hw/input/adb.c
> index 013fcc9c54..84331b9fce 100644
> --- a/hw/input/adb.c
> +++ b/hw/input/adb.c
> @@ -309,6 +309,7 @@ static void adb_device_class_init(ObjectClass *oc, void 
> *data)
>  static const TypeInfo adb_device_type_info = {
>  .name = TYPE_ADB_DEVICE,
>  .parent = TYPE_DEVICE,
> +.class_size = sizeof(ADBDeviceClass),
>  .instance_size = sizeof(ADBDevice),
>  .abstract = true,
>  .class_init = adb_device_class_init,
> 

[PATCH v2 1/3] adb: Correct class size on TYPE_ADB_DEVICE

[David Gibson]

The TypeInfo incorrectly just lets the class size be inherited.  It won't
actually break things, since the class is abstract, but we should get it
right.

Signed-off-by: David Gibson 
---
 hw/input/adb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/input/adb.c b/hw/input/adb.c
index 013fcc9c54..84331b9fce 100644
--- a/hw/input/adb.c
+++ b/hw/input/adb.c
@@ -309,6 +309,7 @@ static void adb_device_class_init(ObjectClass *oc, void 
*data)
 static const TypeInfo adb_device_type_info = {
 .name = TYPE_ADB_DEVICE,
 .parent = TYPE_DEVICE,
+.class_size = sizeof(ADBDeviceClass),
 .instance_size = sizeof(ADBDevice),
 .abstract = true,
 .class_init = adb_device_class_init,
-- 
2.26.2