Re: [PATCH v2 15/15] tests/qtest: Free GThread

[Peter Maydell]

On Thu, 27 Jun 2024 at 14:41, Akihiko Odaki  wrote:
>
> These GThreads are never referenced.
>
> Signed-off-by: Akihiko Odaki 
> ---

Reviewed-by: Peter Maydell 

thanks
-- PMM

[PATCH v2 15/15] tests/qtest: Free GThread

[Akihiko Odaki]

These GThreads are never referenced.

Signed-off-by: Akihiko Odaki 
---
 tests/qtest/vhost-user-test.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c
index d4e437265f66..929af5c183ce 100644
--- a/tests/qtest/vhost-user-test.c
+++ b/tests/qtest/vhost-user-test.c
@@ -928,7 +928,7 @@ static void *vhost_user_test_setup_reconnect(GString 
*cmd_line, void *arg)
 {
 TestServer *s = test_server_new("reconnect", arg);
 
-g_thread_new("connect", connect_thread, s);
+g_thread_unref(g_thread_new("connect", connect_thread, s));
 append_mem_opts(s, cmd_line, 256, TEST_MEMFD_AUTO);
 s->vu_ops->append_opts(s, cmd_line, ",server=on");
 
@@ -965,7 +965,7 @@ static void *vhost_user_test_setup_connect_fail(GString 
*cmd_line, void *arg)
 
 s->test_fail = true;
 
-g_thread_new("connect", connect_thread, s);
+g_thread_unref(g_thread_new("connect", connect_thread, s));
 append_mem_opts(s, cmd_line, 256, TEST_MEMFD_AUTO);
 s->vu_ops->append_opts(s, cmd_line, ",server=on");
 
@@ -980,7 +980,7 @@ static void *vhost_user_test_setup_flags_mismatch(GString 
*cmd_line, void *arg)
 
 s->test_flags = TEST_FLAGS_DISCONNECT;
 
-g_thread_new("connect", connect_thread, s);
+g_thread_unref(g_thread_new("connect", connect_thread, s));
 append_mem_opts(s, cmd_line, 256, TEST_MEMFD_AUTO);
 s->vu_ops->append_opts(s, cmd_line, ",server=on");
 

-- 
2.45.2