Re: [PATCH v2 23/23] test-clone-visitor: Correct an accidental rename

2021-09-24 Thread Markus Armbruster 
Philippe Mathieu-Daudé  writes:

> On 9/17/21 16:31, Markus Armbruster wrote:
>> Commit b359f4b203 "tests: Rename UserDefNativeListUnion to
>> UserDefListUnion" renamed test_clone_native_list() to
>> test_clone_list_union().  The function has nothing to do with unions.
>> Rename it to test_clone_list().
>> 
>> Signed-off-by: Markus Armbruster 
>> Reviewed-by: Eric Blake 
>> ---
>>  tests/unit/test-clone-visitor.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Maybe nitpicking, while this patch is related to the series,
> although I understand you noticed the mistake while working
> on this series, I'd move this cleanup as 1/23.

Not worth a respin.  Next time!

> Reviewed-by: Philippe Mathieu-Daudé 

Thanks!

Re: [PATCH v2 23/23] test-clone-visitor: Correct an accidental rename

2021-09-20 Thread Philippe Mathieu-Daudé 
On 9/17/21 16:31, Markus Armbruster wrote:
> Commit b359f4b203 "tests: Rename UserDefNativeListUnion to
> UserDefListUnion" renamed test_clone_native_list() to
> test_clone_list_union().  The function has nothing to do with unions.
> Rename it to test_clone_list().
> 
> Signed-off-by: Markus Armbruster 
> Reviewed-by: Eric Blake 
> ---
>  tests/unit/test-clone-visitor.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Maybe nitpicking, while this patch is related to the series,
although I understand you noticed the mistake while working
on this series, I'd move this cleanup as 1/23.

Reviewed-by: Philippe Mathieu-Daudé

[PATCH v2 23/23] test-clone-visitor: Correct an accidental rename

2021-09-17 Thread Markus Armbruster 
Commit b359f4b203 "tests: Rename UserDefNativeListUnion to
UserDefListUnion" renamed test_clone_native_list() to
test_clone_list_union().  The function has nothing to do with unions.
Rename it to test_clone_list().

Signed-off-by: Markus Armbruster 
Reviewed-by: Eric Blake 
---
 tests/unit/test-clone-visitor.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/unit/test-clone-visitor.c b/tests/unit/test-clone-visitor.c
index 4048018607..5d48e125b8 100644
--- a/tests/unit/test-clone-visitor.c
+++ b/tests/unit/test-clone-visitor.c
@@ -63,7 +63,7 @@ static void test_clone_alternate(void)
 qapi_free_AltEnumBool(s_dst);
 }
 
-static void test_clone_list_union(void)
+static void test_clone_list(void)
 {
 uint8List *src = NULL, *dst;
 uint8List *tmp = NULL;
@@ -203,7 +203,7 @@ int main(int argc, char **argv)
 
 g_test_add_func("/visitor/clone/struct", test_clone_struct);
 g_test_add_func("/visitor/clone/alternate", test_clone_alternate);
-g_test_add_func("/visitor/clone/list_union", test_clone_list_union);
+g_test_add_func("/visitor/clone/list", test_clone_list);
 g_test_add_func("/visitor/clone/empty", test_clone_empty);
 g_test_add_func("/visitor/clone/complex1", test_clone_complex1);
 g_test_add_func("/visitor/clone/complex2", test_clone_complex2);
-- 
2.31.1