Re: [PATCH v3 0/3] Add npcm7xx emc model
On Thu, Feb 11, 2021 at 11:48 AM Peter Maydell
wrote:
> On Thu, 11 Feb 2021 at 11:34, Peter Maydell
> wrote:
> >
> > On Tue, 9 Feb 2021 at 01:55, Doug Evans wrote:
> > >
> > > This is a 10/100 ethernet device that has several features.
> > > Only the ones needed by the Linux driver have been implemented.
> > > See npcm7xx_emc.c for a list of unimplemented features.
> > >
> > > Doug Evans (3):
> > > hw/net: Add npcm7xx emc model
> > > hw/arm: Add npcm7xx emc model
> > > tests/qtests: Add npcm7xx emc model test
> > >
> >
> >
> >
> > Applied to target-arm.next, thanks.
>
> Dropped again; the new tests fail on big-endian hosts (s390x, ppc64):
>
> MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
> QTEST_QEMU_IMG=./qemu-img
> G_TEST_DBUS_DAEMON=/home/ubuntu/qemu/tests/dbus-vmstate-daemon.sh
> QTEST_QEMU_BINARY=./qemu-system-arm tests/qtest/npcm7xx_emc-test --tap
> -k
> PASS 1 qtest-arm/npcm7xx_emc-test /arm/npcm7xx_emc/emc[0]/init
> **
> ERROR:../../tests/qtest/npcm7xx_emc-test.c:476:emc_send_verify1:
> assertion failed ((result_desc.status_and_length & expected_mask) ==
> expected_value): (0x == 0x0008)
> ERROR qtest-arm/npcm7xx_emc-test - Bail out!
> ERROR:../../tests/qtest/npcm7xx_emc-test.c:476:emc_send_verify1:
> assertion failed ((result_desc.status_and_length & expected_mask) ==
> expected_value): (0x == 0x0008)
>
Fixed in V4:
https://lists.nongnu.org/archive/html/qemu-devel/2021-02/msg04529.html
Re: [PATCH v3 0/3] Add npcm7xx emc model
On Thu, 11 Feb 2021 at 11:34, Peter Maydell wrote:
>
> On Tue, 9 Feb 2021 at 01:55, Doug Evans wrote:
> >
> > This is a 10/100 ethernet device that has several features.
> > Only the ones needed by the Linux driver have been implemented.
> > See npcm7xx_emc.c for a list of unimplemented features.
> >
> > Doug Evans (3):
> > hw/net: Add npcm7xx emc model
> > hw/arm: Add npcm7xx emc model
> > tests/qtests: Add npcm7xx emc model test
> >
>
>
>
> Applied to target-arm.next, thanks.
Dropped again; the new tests fail on big-endian hosts (s390x, ppc64):
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
QTEST_QEMU_IMG=./qemu-img
G_TEST_DBUS_DAEMON=/home/ubuntu/qemu/tests/dbus-vmstate-daemon.sh
QTEST_QEMU_BINARY=./qemu-system-arm tests/qtest/npcm7xx_emc-test --tap
-k
PASS 1 qtest-arm/npcm7xx_emc-test /arm/npcm7xx_emc/emc[0]/init
**
ERROR:../../tests/qtest/npcm7xx_emc-test.c:476:emc_send_verify1:
assertion failed ((result_desc.status_and_length & expected_mask) ==
expected_value): (0x == 0x0008)
ERROR qtest-arm/npcm7xx_emc-test - Bail out!
ERROR:../../tests/qtest/npcm7xx_emc-test.c:476:emc_send_verify1:
assertion failed ((result_desc.status_and_length & expected_mask) ==
expected_value): (0x == 0x0008)
-- PMM
Re: [PATCH v3 0/3] Add npcm7xx emc model
On Tue, 9 Feb 2021 at 01:55, Doug Evans wrote: > > This is a 10/100 ethernet device that has several features. > Only the ones needed by the Linux driver have been implemented. > See npcm7xx_emc.c for a list of unimplemented features. > > Doug Evans (3): > hw/net: Add npcm7xx emc model > hw/arm: Add npcm7xx emc model > tests/qtests: Add npcm7xx emc model test > Applied to target-arm.next, thanks. -- PMM
[PATCH v3 0/3] Add npcm7xx emc model
This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Doug Evans (3): hw/net: Add npcm7xx emc model hw/arm: Add npcm7xx emc model tests/qtests: Add npcm7xx emc model test docs/system/arm/nuvoton.rst| 3 +- hw/arm/npcm7xx.c | 50 +- hw/net/meson.build | 1 + hw/net/npcm7xx_emc.c | 857 + hw/net/trace-events| 17 + include/hw/arm/npcm7xx.h | 2 + include/hw/net/npcm7xx_emc.h | 286 +++ tests/qtest/meson.build| 1 + tests/qtest/npcm7xx_emc-test.c | 812 +++ 9 files changed, 2026 insertions(+), 3 deletions(-) create mode 100644 hw/net/npcm7xx_emc.c create mode 100644 include/hw/net/npcm7xx_emc.h create mode 100644 tests/qtest/npcm7xx_emc-test.c -- 2.30.0.478.g8a0d178c01-goog Differences from v2: 1/3 hw/net: Add npcm7xx emc model - move call to qemu_set_irq - remove use of C99 mixed decls/statements - add use of g_autofree 2/3 hw/arm: Add npcm7xx emc model - none, patch ok as is 3/3 tests/qtests: Add npcm7xx emc model test - remove use of C99 mixed decls/statements
