Re: [PATCH v3 00/13] hw/arm/raspi: Dynamically create machines based on the board revision
On Sat, 8 Feb 2020 at 16:57, Philippe Mathieu-Daudé wrote: > > Hi, > > This series is a preparatory to easily add the raspi0/raspi1/raspi4 > boards (see [1]). > > Igor has been working in his "refactor main RAM allocation to use > hostmem backend" series, and now v4 [2] is almost reviewed. > > His raspi patch [3] clashes with my work, Since it is easier for > him to apply his on top of mine, I am sending these patches first. > > Since v2: > - Split of bigger series (30 patches was scary) > - addressed Zoltan review comments > > Phil. > > [1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg677145.html > [2] https://www.mail-archive.com/qemu-devel@nongnu.org/msg675738.html > [3] https://www.mail-archive.com/qemu-devel@nongnu.org/msg675752.html > Supersedes: <20200206011756.2413-1-f4...@amsat.org> I had one or two minor comments but I'm happy if we address those in follow-up patches. Applied to target-arm.next with the commit message tweak for patch 13 suggested by Igor. thanks -- PMM
[PATCH v3 00/13] hw/arm/raspi: Dynamically create machines based on the board revision
Hi, This series is a preparatory to easily add the raspi0/raspi1/raspi4 boards (see [1]). Igor has been working in his "refactor main RAM allocation to use hostmem backend" series, and now v4 [2] is almost reviewed. His raspi patch [3] clashes with my work, Since it is easier for him to apply his on top of mine, I am sending these patches first. Since v2: - Split of bigger series (30 patches was scary) - addressed Zoltan review comments Phil. [1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg677145.html [2] https://www.mail-archive.com/qemu-devel@nongnu.org/msg675738.html [3] https://www.mail-archive.com/qemu-devel@nongnu.org/msg675752.html Supersedes: <20200206011756.2413-1-f4...@amsat.org> Philippe Mathieu-Daudé (13): hw/arm/raspi: Use BCM2708 machine type with pre Device Tree kernels hw/arm/raspi: Correct the board descriptions hw/arm/raspi: Extract the version from the board revision hw/arm/raspi: Extract the RAM size from the board revision hw/arm/raspi: Extract the processor type from the board revision hw/arm/raspi: Trivial code movement hw/arm/raspi: Make machines children of abstract RaspiMachineClass hw/arm/raspi: Make board_rev a field of RaspiMachineClass hw/arm/raspi: Let class_init() directly call raspi_machine_init() hw/arm/raspi: Set default RAM size to size encoded in board revision hw/arm/raspi: Extract the board model from the board revision hw/arm/raspi: Use a unique raspi_machine_class_init() method hw/arm/raspi: Extract the cores count from the board revision hw/arm/raspi.c | 190 + 1 file changed, 143 insertions(+), 47 deletions(-) -- 2.21.1
