Re: [PATCH v3 23/60] target/arm: Use tcg_constant_i32 in translate.h

2022-04-21 Thread Peter Maydell
On Sun, 17 Apr 2022 at 19:05, Richard Henderson
 wrote:
>
> Signed-off-by: Richard Henderson 
> ---
>  target/arm/translate.h | 13 +++--
>  1 file changed, 3 insertions(+), 10 deletions(-)

Reviewed-by: Peter Maydell 

thanks
-- PMM



[PATCH v3 23/60] target/arm: Use tcg_constant_i32 in translate.h

2022-04-17 Thread Richard Henderson
Signed-off-by: Richard Henderson 
---
 target/arm/translate.h | 13 +++--
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/target/arm/translate.h b/target/arm/translate.h
index 050d80f6f9..6f0ebdc88e 100644
--- a/target/arm/translate.h
+++ b/target/arm/translate.h
@@ -332,16 +332,9 @@ static inline void gen_ss_advance(DisasContext *s)
 static inline void gen_exception(int excp, uint32_t syndrome,
  uint32_t target_el)
 {
-TCGv_i32 tcg_excp = tcg_const_i32(excp);
-TCGv_i32 tcg_syn = tcg_const_i32(syndrome);
-TCGv_i32 tcg_el = tcg_const_i32(target_el);
-
-gen_helper_exception_with_syndrome(cpu_env, tcg_excp,
-   tcg_syn, tcg_el);
-
-tcg_temp_free_i32(tcg_el);
-tcg_temp_free_i32(tcg_syn);
-tcg_temp_free_i32(tcg_excp);
+gen_helper_exception_with_syndrome(cpu_env, tcg_constant_i32(excp),
+   tcg_constant_i32(syndrome),
+   tcg_constant_i32(target_el));
 }
 
 /* Generate an architectural singlestep exception */
-- 
2.25.1