Re: [PATCH v3 3/6] target/arm: make ARMCPU.ctr 64-bit

[Laurent Desnogues]

On Fri, Jan 8, 2021 at 7:51 PM Leif Lindholm  wrote:
>
> When FEAT_MTE is implemented, the AArch64 view of CTR_EL0 adds the
> TminLine field in bits [37:32].
> Extend the ctr field to be able to hold this context.
>
> Signed-off-by: Leif Lindholm 

Reviewed-by: Laurent Desnogues 

Thanks,

Laurent

> ---
>  target/arm/cpu.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/cpu.h b/target/arm/cpu.h
> index fadd1a47df..063228de2a 100644
> --- a/target/arm/cpu.h
> +++ b/target/arm/cpu.h
> @@ -931,7 +931,7 @@ struct ARMCPU {
>  uint64_t midr;
>  uint32_t revidr;
>  uint32_t reset_fpsid;
> -uint32_t ctr;
> +uint64_t ctr;
>  uint32_t reset_sctlr;
>  uint64_t pmceid0;
>  uint64_t pmceid1;
> --
> 2.20.1
>

Re: [PATCH v3 3/6] target/arm: make ARMCPU.ctr 64-bit

[Richard Henderson]

On 1/8/21 8:51 AM, Leif Lindholm wrote:
> When FEAT_MTE is implemented, the AArch64 view of CTR_EL0 adds the
> TminLine field in bits [37:32].
> Extend the ctr field to be able to hold this context.
> 
> Signed-off-by: Leif Lindholm 
> ---
>  target/arm/cpu.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson 

r~

Re: [PATCH v3 3/6] target/arm: make ARMCPU.ctr 64-bit

[Hao Wu via]

On Fri, Jan 8, 2021 at 10:54 AM Leif Lindholm  wrote:

> When FEAT_MTE is implemented, the AArch64 view of CTR_EL0 adds the
> TminLine field in bits [37:32].
> Extend the ctr field to be able to hold this context.
>
> Signed-off-by: Leif Lindholm 
>
Reviewed-by: Hao Wu 

> ---
>  target/arm/cpu.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/cpu.h b/target/arm/cpu.h
> index fadd1a47df..063228de2a 100644
> --- a/target/arm/cpu.h
> +++ b/target/arm/cpu.h
> @@ -931,7 +931,7 @@ struct ARMCPU {
>  uint64_t midr;
>  uint32_t revidr;
>  uint32_t reset_fpsid;
> -uint32_t ctr;
> +uint64_t ctr;
>  uint32_t reset_sctlr;
>  uint64_t pmceid0;
>  uint64_t pmceid1;
> --
> 2.20.1
>
>
>

[PATCH v3 3/6] target/arm: make ARMCPU.ctr 64-bit

[Leif Lindholm]

When FEAT_MTE is implemented, the AArch64 view of CTR_EL0 adds the
TminLine field in bits [37:32].
Extend the ctr field to be able to hold this context.

Signed-off-by: Leif Lindholm 
---
 target/arm/cpu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index fadd1a47df..063228de2a 100644
--- a/target/arm/cpu.h
+++ b/target/arm/cpu.h
@@ -931,7 +931,7 @@ struct ARMCPU {
 uint64_t midr;
 uint32_t revidr;
 uint32_t reset_fpsid;
-uint32_t ctr;
+uint64_t ctr;
 uint32_t reset_sctlr;
 uint64_t pmceid0;
 uint64_t pmceid1;
-- 
2.20.1