Cover letters: v1: https://lists.nongnu.org/archive/html/qemu-block/2021-01/msg00254.html v2: https://lists.nongnu.org/archive/html/qemu-block/2021-01/msg00296.html v3: https://lists.nongnu.org/archive/html/qemu-block/2021-01/msg00371.html
git: https://github.com/XanClic/qemu.git fix-129-2-v4 https://git.xanclic.moe/XanClic/qemu.git fix-129-2-v4 Hi, See the v1 cover letter above for the main point of this series (it’s just that all patch indices are shifted up by two). The main change in v2 is the extension of iotest 297 to run pylint and mypy not only on iotests.py, but on every Python file in the qemu-iotests/ directory that isn’t part of a skip list. The main changes in v3 are that 297 is rewritten in Python, that patch 1 is added (which helps tests to pass mypy scrutiny without having to assert that vital variables such as iotests.test_dir are not None), and that patch 10 is added (because I was already modifying 300 in patch 1, so I thought i might as well). Change in v4 (from v3): - Patch 2: - Fix flake8 complaints (PEP8 violations) - Modify only a copy of os.environ, and pass that down to pylint and mypy (instead of accidentally modifying os.environ itself) - s/text=True/universal_newlines=True/ (@text was added in Python 3.7, but qemu requires only 3.6) - Patch 6: - Fix flake8 complaints (PEP8 violations); kept R-bs, it’s just a question of indentation - Patch 9: - Mention modification to 297 in the commit message - Patch 10: - Mention modification to 297 in the commit message - s/PYTHONPATH/sys.path/ - Fix flake8 complaints (PEP8 violations) git-backport-diff of v3 <-> v4: Key: [----] : patches are identical [####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively 001/10:[----] [--] 'iotests.py: Assume a couple of variables as given' 002/10:[0007] [FC] 'iotests/297: Rewrite in Python and extend reach' 003/10:[----] [--] 'iotests: Move try_remove to iotests.py' 004/10:[----] [--] 'iotests/129: Remove test images in tearDown()' 005/10:[----] [--] 'iotests/129: Do not check @busy' 006/10:[0004] [FC] 'iotests/129: Use throttle node' 007/10:[----] [-C] 'iotests/129: Actually test a commit job' 008/10:[----] [--] 'iotests/129: Limit mirror job's buffer size' 009/10:[----] [--] 'iotests/129: Clean up pylint and mypy complaints' 010/10:[0006] [FC] 'iotests/300: Clean up pylint and mypy complaints' Max Reitz (10): iotests.py: Assume a couple of variables as given iotests/297: Rewrite in Python and extend reach iotests: Move try_remove to iotests.py iotests/129: Remove test images in tearDown() iotests/129: Do not check @busy iotests/129: Use throttle node iotests/129: Actually test a commit job iotests/129: Limit mirror job's buffer size iotests/129: Clean up pylint and mypy complaints iotests/300: Clean up pylint and mypy complaints tests/qemu-iotests/124 | 8 +-- tests/qemu-iotests/129 | 72 +++++++++++++--------- tests/qemu-iotests/297 | 110 +++++++++++++++++++++++++++------- tests/qemu-iotests/297.out | 5 +- tests/qemu-iotests/300 | 19 ++++-- tests/qemu-iotests/iotests.py | 37 ++++++------ 6 files changed, 169 insertions(+), 82 deletions(-) -- 2.29.2