Re: [PATCH v4 06/11] Update PowerPC AT_HWCAP2 definition

2020-07-14 Thread Lijun Pan


> On Jul 13, 2020, at 6:47 PM, David Gibson  wrote:
> 
> On Mon, Jul 13, 2020 at 02:20:20PM -0500, Lijun Pan wrote:
>> 
>> 
>>> On Jul 13, 2020, at 12:14 AM, David Gibson  
>>> wrote:
>>> 
>>> On Wed, Jul 01, 2020 at 06:43:41PM -0500, Lijun Pan wrote:
 Add PPC2_FEATURE2_ARCH_3_10 to the PowerPC AT_HWCAP2 definitions.
 
 Signed-off-by: Lijun Pan 
 ---
 v4: add missing changes, and split to 5/11, 6/11, 7/11
 v3: use tcg_gen_gvec_mul()
 v2: fix coding style
   use Power ISA 3.1 flag
 
 include/elf.h | 1 +
 1 file changed, 1 insertion(+)
 
 diff --git a/include/elf.h b/include/elf.h
 index 8fbfe60e09..1858b95acf 100644
 --- a/include/elf.h
 +++ b/include/elf.h
 @@ -554,6 +554,7 @@ typedef struct {
 #define PPC_FEATURE2_HTM_NOSC   0x0100
 #define PPC_FEATURE2_ARCH_3_00  0x0080
 #define PPC_FEATURE2_HAS_IEEE1280x0040
 +#define PPC_FEATURE2_ARCH_3_10  0x0020
 
 /* Bits present in AT_HWCAP for Sparc.  */
>>> 
>>> 
>>> Um.. in the corresponding #defines in the kernel 0x0020 is given
>>> to PPC_FEATURE2_DARN, and several more bits are allocated past that
>>> point.
>> 
>> Then what do you recommend to use?
> 
> This is part of exposed userland ABI, so it needs to be standardized
> at least semi-formally.  I'm not actually sure who allocates these in
> general.

Anton,

Do you know the allocation standard since you made the last change into elf.h?

Lijun

> 
> -- 
> David Gibson  | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au | 
> minimalist, thank you.  NOT _the_ _other_
>   | _way_ _around_!
> http://www.ozlabs.org/~dgibson 


Re: [PATCH v4 06/11] Update PowerPC AT_HWCAP2 definition

2020-07-13 Thread David Gibson
On Mon, Jul 13, 2020 at 02:20:20PM -0500, Lijun Pan wrote:
> 
> 
> > On Jul 13, 2020, at 12:14 AM, David Gibson  
> > wrote:
> > 
> > On Wed, Jul 01, 2020 at 06:43:41PM -0500, Lijun Pan wrote:
> >> Add PPC2_FEATURE2_ARCH_3_10 to the PowerPC AT_HWCAP2 definitions.
> >> 
> >> Signed-off-by: Lijun Pan 
> >> ---
> >> v4: add missing changes, and split to 5/11, 6/11, 7/11
> >> v3: use tcg_gen_gvec_mul()
> >> v2: fix coding style
> >>use Power ISA 3.1 flag
> >> 
> >> include/elf.h | 1 +
> >> 1 file changed, 1 insertion(+)
> >> 
> >> diff --git a/include/elf.h b/include/elf.h
> >> index 8fbfe60e09..1858b95acf 100644
> >> --- a/include/elf.h
> >> +++ b/include/elf.h
> >> @@ -554,6 +554,7 @@ typedef struct {
> >> #define PPC_FEATURE2_HTM_NOSC   0x0100
> >> #define PPC_FEATURE2_ARCH_3_00  0x0080
> >> #define PPC_FEATURE2_HAS_IEEE1280x0040
> >> +#define PPC_FEATURE2_ARCH_3_10  0x0020
> >> 
> >> /* Bits present in AT_HWCAP for Sparc.  */
> > 
> > 
> > Um.. in the corresponding #defines in the kernel 0x0020 is given
> > to PPC_FEATURE2_DARN, and several more bits are allocated past that
> > point.
> 
> Then what do you recommend to use?

This is part of exposed userland ABI, so it needs to be standardized
at least semi-formally.  I'm not actually sure who allocates these in
general.

-- 
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson


signature.asc
Description: PGP signature


Re: [PATCH v4 06/11] Update PowerPC AT_HWCAP2 definition

2020-07-13 Thread Lijun Pan


> On Jul 13, 2020, at 12:14 AM, David Gibson  
> wrote:
> 
> On Wed, Jul 01, 2020 at 06:43:41PM -0500, Lijun Pan wrote:
>> Add PPC2_FEATURE2_ARCH_3_10 to the PowerPC AT_HWCAP2 definitions.
>> 
>> Signed-off-by: Lijun Pan 
>> ---
>> v4: add missing changes, and split to 5/11, 6/11, 7/11
>> v3: use tcg_gen_gvec_mul()
>> v2: fix coding style
>>use Power ISA 3.1 flag
>> 
>> include/elf.h | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/include/elf.h b/include/elf.h
>> index 8fbfe60e09..1858b95acf 100644
>> --- a/include/elf.h
>> +++ b/include/elf.h
>> @@ -554,6 +554,7 @@ typedef struct {
>> #define PPC_FEATURE2_HTM_NOSC   0x0100
>> #define PPC_FEATURE2_ARCH_3_00  0x0080
>> #define PPC_FEATURE2_HAS_IEEE1280x0040
>> +#define PPC_FEATURE2_ARCH_3_10  0x0020
>> 
>> /* Bits present in AT_HWCAP for Sparc.  */
> 
> 
> Um.. in the corresponding #defines in the kernel 0x0020 is given
> to PPC_FEATURE2_DARN, and several more bits are allocated past that
> point.
> 

Then what do you recommend to use?

Thanks,
Lijun



Re: [PATCH v4 06/11] Update PowerPC AT_HWCAP2 definition

2020-07-12 Thread David Gibson
On Wed, Jul 01, 2020 at 06:43:41PM -0500, Lijun Pan wrote:
> Add PPC2_FEATURE2_ARCH_3_10 to the PowerPC AT_HWCAP2 definitions.
> 
> Signed-off-by: Lijun Pan 
> ---
> v4: add missing changes, and split to 5/11, 6/11, 7/11
> v3: use tcg_gen_gvec_mul()
> v2: fix coding style
> use Power ISA 3.1 flag
> 
>  include/elf.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/elf.h b/include/elf.h
> index 8fbfe60e09..1858b95acf 100644
> --- a/include/elf.h
> +++ b/include/elf.h
> @@ -554,6 +554,7 @@ typedef struct {
>  #define PPC_FEATURE2_HTM_NOSC   0x0100
>  #define PPC_FEATURE2_ARCH_3_00  0x0080
>  #define PPC_FEATURE2_HAS_IEEE1280x0040
> +#define PPC_FEATURE2_ARCH_3_10  0x0020
>  
>  /* Bits present in AT_HWCAP for Sparc.  */


Um.. in the corresponding #defines in the kernel 0x0020 is given
to PPC_FEATURE2_DARN, and several more bits are allocated past that
point.

-- 
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson


signature.asc
Description: PGP signature


[PATCH v4 06/11] Update PowerPC AT_HWCAP2 definition

2020-07-01 Thread Lijun Pan
Add PPC2_FEATURE2_ARCH_3_10 to the PowerPC AT_HWCAP2 definitions.

Signed-off-by: Lijun Pan 
---
v4: add missing changes, and split to 5/11, 6/11, 7/11
v3: use tcg_gen_gvec_mul()
v2: fix coding style
use Power ISA 3.1 flag

 include/elf.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/elf.h b/include/elf.h
index 8fbfe60e09..1858b95acf 100644
--- a/include/elf.h
+++ b/include/elf.h
@@ -554,6 +554,7 @@ typedef struct {
 #define PPC_FEATURE2_HTM_NOSC   0x0100
 #define PPC_FEATURE2_ARCH_3_00  0x0080
 #define PPC_FEATURE2_HAS_IEEE1280x0040
+#define PPC_FEATURE2_ARCH_3_10  0x0020
 
 /* Bits present in AT_HWCAP for Sparc.  */
 
-- 
2.23.0