Re: [PATCH v4 07/18] block/reqlist: reqlist_find_conflict(): use ranges_overlap()

[Hanna Reitz]

On 16.02.22 20:46, Vladimir Sementsov-Ogievskiy wrote:

Let's reuse convenient helper.

Signed-off-by: Vladimir Sementsov-Ogievskiy 
---
  block/reqlist.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)


Reviewed-by: Hanna Reitz 

[PATCH v4 07/18] block/reqlist: reqlist_find_conflict(): use ranges_overlap()

[Vladimir Sementsov-Ogievskiy]

Let's reuse convenient helper.

Signed-off-by: Vladimir Sementsov-Ogievskiy 
---
 block/reqlist.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/block/reqlist.c b/block/reqlist.c
index 5e320ba649..09fecbd48c 100644
--- a/block/reqlist.c
+++ b/block/reqlist.c
@@ -13,6 +13,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/range.h"
 
 #include "block/reqlist.h"
 
@@ -35,7 +36,7 @@ BlockReq *reqlist_find_conflict(BlockReqList *reqs, int64_t 
offset,
 BlockReq *r;
 
 QLIST_FOREACH(r, reqs, list) {
-if (offset + bytes > r->offset && offset < r->offset + r->bytes) {
+if (ranges_overlap(offset, bytes, r->offset, r->bytes)) {
 return r;
 }
 }
-- 
2.31.1