Re: [PATCH v4 30/46] qapi/gen.py: Fix edge-case of _is_user_module

[Eduardo Habkost]

On Wed, Sep 30, 2020 at 12:31:34AM -0400, John Snow wrote:
> The edge case is that if the name is '', this expression returns a
> string instead of a bool, which violates our declared type.
> 
> Signed-off-by: John Snow 
> Reviewed-by: Cleber Rosa 

Reviewed-by: Eduardo Habkost 

-- 
Eduardo

[PATCH v4 30/46] qapi/gen.py: Fix edge-case of _is_user_module

[John Snow]

The edge case is that if the name is '', this expression returns a
string instead of a bool, which violates our declared type.

Signed-off-by: John Snow 
Reviewed-by: Cleber Rosa 
---
 scripts/qapi/gen.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py
index b8a6fe8a5c3..58cc1d8e734 100644
--- a/scripts/qapi/gen.py
+++ b/scripts/qapi/gen.py
@@ -243,7 +243,7 @@ def __init__(self, prefix, what, user_blurb, builtin_blurb, 
pydoc):
 
 @staticmethod
 def _is_user_module(name):
-return name and not name.startswith('./')
+return bool(name and not name.startswith('./'))
 
 @staticmethod
 def _is_builtin_module(name):
-- 
2.26.2