Re: [PATCH v5 00/15] hw/nvme: SR-IOV with Virtualization Enhancements
On Fri, Feb 18, 2022 at 03:23:15AM -0500, Michael S. Tsirkin wrote: > On Thu, Feb 17, 2022 at 06:44:49PM +0100, Lukasz Maniak wrote: > > Changes since v4: > > - Added hello world example for SR-IOV to the docs > > - Moved AER initialization from nvme_init_ctrl to nvme_init_state > > - Fixed division by zero issue in calculation of vqfrt and vifrt > > capabilities > > > BTW you should copy all reviewers on the cover letter. > Yep, will do next time. Sorry about that. > > > > Knut Omang (2): > > pcie: Add support for Single Root I/O Virtualization (SR/IOV) > > pcie: Add some SR/IOV API documentation in docs/pcie_sriov.txt > > > > Lukasz Maniak (4): > > hw/nvme: Add support for SR-IOV > > hw/nvme: Add support for Primary Controller Capabilities > > hw/nvme: Add support for Secondary Controller List > > docs: Add documentation for SR-IOV and Virtualization Enhancements > > > > Łukasz Gieryk (9): > > pcie: Add a helper to the SR/IOV API > > pcie: Add 1.2 version token for the Power Management Capability > > hw/nvme: Implement the Function Level Reset > > hw/nvme: Make max_ioqpairs and msix_qsize configurable in runtime > > hw/nvme: Remove reg_size variable and update BAR0 size calculation > > hw/nvme: Calculate BAR attributes in a function > > hw/nvme: Initialize capability structures for primary/secondary > > controllers > > hw/nvme: Add support for the Virtualization Management command > > hw/nvme: Update the initalization place for the AER queue > > > > docs/pcie_sriov.txt | 115 ++ > > docs/system/devices/nvme.rst | 82 + > > hw/nvme/ctrl.c | 674 --- > > hw/nvme/ns.c | 2 +- > > hw/nvme/nvme.h | 55 ++- > > hw/nvme/subsys.c | 75 +++- > > hw/nvme/trace-events | 6 + > > hw/pci/meson.build | 1 + > > hw/pci/pci.c | 100 -- > > hw/pci/pcie.c| 5 + > > hw/pci/pcie_sriov.c | 302 > > hw/pci/trace-events | 5 + > > include/block/nvme.h | 65 > > include/hw/pci/pci.h | 12 +- > > include/hw/pci/pci_ids.h | 1 + > > include/hw/pci/pci_regs.h| 1 + > > include/hw/pci/pcie.h| 6 + > > include/hw/pci/pcie_sriov.h | 77 > > include/qemu/typedefs.h | 2 + > > 19 files changed, 1505 insertions(+), 81 deletions(-) > > create mode 100644 docs/pcie_sriov.txt > > create mode 100644 hw/pci/pcie_sriov.c > > create mode 100644 include/hw/pci/pcie_sriov.h > > > > -- > > 2.25.1 > > > > > > >
Re: [PATCH v5 00/15] hw/nvme: SR-IOV with Virtualization Enhancements
On Fri, Feb 18, 2022 at 09:51:12AM +0100, Klaus Jensen wrote: > On Feb 18 03:26, Michael S. Tsirkin wrote: > > On Thu, Feb 17, 2022 at 06:44:49PM +0100, Lukasz Maniak wrote: > > > Changes since v4: > > > - Added hello world example for SR-IOV to the docs > > > - Moved AER initialization from nvme_init_ctrl to nvme_init_state > > > - Fixed division by zero issue in calculation of vqfrt and vifrt > > > capabilities > > > > > > So do you want to merge it all with nvme bits? which tree is this for? > > Or would you like me to merge the pci bits for now? > > Thanks! > > > > I was wondering how to approach that as well. I think maybe it could all > go through your tree so the pcie bits doesnt just sit their without > being used by anything? It's up to you, but note that nvme bits are not > fully reviewed yet. > > If you are fine with merging the pcie bits then lets do that and we > merge the nvme bits through the nvme tree. The nvme bits is fully acked, > so it will go in, just need to finalize the reviews. Yes, I'm fine with this. -- MST
Re: [PATCH v5 00/15] hw/nvme: SR-IOV with Virtualization Enhancements
On Feb 18 03:26, Michael S. Tsirkin wrote: > On Thu, Feb 17, 2022 at 06:44:49PM +0100, Lukasz Maniak wrote: > > Changes since v4: > > - Added hello world example for SR-IOV to the docs > > - Moved AER initialization from nvme_init_ctrl to nvme_init_state > > - Fixed division by zero issue in calculation of vqfrt and vifrt > > capabilities > > > So do you want to merge it all with nvme bits? which tree is this for? > Or would you like me to merge the pci bits for now? > Thanks! > I was wondering how to approach that as well. I think maybe it could all go through your tree so the pcie bits doesnt just sit their without being used by anything? It's up to you, but note that nvme bits are not fully reviewed yet. If you are fine with merging the pcie bits then lets do that and we merge the nvme bits through the nvme tree. The nvme bits is fully acked, so it will go in, just need to finalize the reviews. signature.asc Description: PGP signature
Re: [PATCH v5 00/15] hw/nvme: SR-IOV with Virtualization Enhancements
On Thu, Feb 17, 2022 at 06:44:49PM +0100, Lukasz Maniak wrote: > Changes since v4: > - Added hello world example for SR-IOV to the docs > - Moved AER initialization from nvme_init_ctrl to nvme_init_state > - Fixed division by zero issue in calculation of vqfrt and vifrt > capabilities BTW you should copy all reviewers on the cover letter. > Knut Omang (2): > pcie: Add support for Single Root I/O Virtualization (SR/IOV) > pcie: Add some SR/IOV API documentation in docs/pcie_sriov.txt > > Lukasz Maniak (4): > hw/nvme: Add support for SR-IOV > hw/nvme: Add support for Primary Controller Capabilities > hw/nvme: Add support for Secondary Controller List > docs: Add documentation for SR-IOV and Virtualization Enhancements > > Łukasz Gieryk (9): > pcie: Add a helper to the SR/IOV API > pcie: Add 1.2 version token for the Power Management Capability > hw/nvme: Implement the Function Level Reset > hw/nvme: Make max_ioqpairs and msix_qsize configurable in runtime > hw/nvme: Remove reg_size variable and update BAR0 size calculation > hw/nvme: Calculate BAR attributes in a function > hw/nvme: Initialize capability structures for primary/secondary > controllers > hw/nvme: Add support for the Virtualization Management command > hw/nvme: Update the initalization place for the AER queue > > docs/pcie_sriov.txt | 115 ++ > docs/system/devices/nvme.rst | 82 + > hw/nvme/ctrl.c | 674 --- > hw/nvme/ns.c | 2 +- > hw/nvme/nvme.h | 55 ++- > hw/nvme/subsys.c | 75 +++- > hw/nvme/trace-events | 6 + > hw/pci/meson.build | 1 + > hw/pci/pci.c | 100 -- > hw/pci/pcie.c| 5 + > hw/pci/pcie_sriov.c | 302 > hw/pci/trace-events | 5 + > include/block/nvme.h | 65 > include/hw/pci/pci.h | 12 +- > include/hw/pci/pci_ids.h | 1 + > include/hw/pci/pci_regs.h| 1 + > include/hw/pci/pcie.h| 6 + > include/hw/pci/pcie_sriov.h | 77 > include/qemu/typedefs.h | 2 + > 19 files changed, 1505 insertions(+), 81 deletions(-) > create mode 100644 docs/pcie_sriov.txt > create mode 100644 hw/pci/pcie_sriov.c > create mode 100644 include/hw/pci/pcie_sriov.h > > -- > 2.25.1 > > >
Re: [PATCH v5 00/15] hw/nvme: SR-IOV with Virtualization Enhancements
On Thu, Feb 17, 2022 at 06:44:49PM +0100, Lukasz Maniak wrote: > Changes since v4: > - Added hello world example for SR-IOV to the docs > - Moved AER initialization from nvme_init_ctrl to nvme_init_state > - Fixed division by zero issue in calculation of vqfrt and vifrt > capabilities So do you want to merge it all with nvme bits? which tree is this for? Or would you like me to merge the pci bits for now? Thanks! > Knut Omang (2): > pcie: Add support for Single Root I/O Virtualization (SR/IOV) > pcie: Add some SR/IOV API documentation in docs/pcie_sriov.txt > > Lukasz Maniak (4): > hw/nvme: Add support for SR-IOV > hw/nvme: Add support for Primary Controller Capabilities > hw/nvme: Add support for Secondary Controller List > docs: Add documentation for SR-IOV and Virtualization Enhancements > > Łukasz Gieryk (9): > pcie: Add a helper to the SR/IOV API > pcie: Add 1.2 version token for the Power Management Capability > hw/nvme: Implement the Function Level Reset > hw/nvme: Make max_ioqpairs and msix_qsize configurable in runtime > hw/nvme: Remove reg_size variable and update BAR0 size calculation > hw/nvme: Calculate BAR attributes in a function > hw/nvme: Initialize capability structures for primary/secondary > controllers > hw/nvme: Add support for the Virtualization Management command > hw/nvme: Update the initalization place for the AER queue > > docs/pcie_sriov.txt | 115 ++ > docs/system/devices/nvme.rst | 82 + > hw/nvme/ctrl.c | 674 --- > hw/nvme/ns.c | 2 +- > hw/nvme/nvme.h | 55 ++- > hw/nvme/subsys.c | 75 +++- > hw/nvme/trace-events | 6 + > hw/pci/meson.build | 1 + > hw/pci/pci.c | 100 -- > hw/pci/pcie.c| 5 + > hw/pci/pcie_sriov.c | 302 > hw/pci/trace-events | 5 + > include/block/nvme.h | 65 > include/hw/pci/pci.h | 12 +- > include/hw/pci/pci_ids.h | 1 + > include/hw/pci/pci_regs.h| 1 + > include/hw/pci/pcie.h| 6 + > include/hw/pci/pcie_sriov.h | 77 > include/qemu/typedefs.h | 2 + > 19 files changed, 1505 insertions(+), 81 deletions(-) > create mode 100644 docs/pcie_sriov.txt > create mode 100644 hw/pci/pcie_sriov.c > create mode 100644 include/hw/pci/pcie_sriov.h > > -- > 2.25.1 > > >
[PATCH v5 00/15] hw/nvme: SR-IOV with Virtualization Enhancements
Changes since v4: - Added hello world example for SR-IOV to the docs - Moved AER initialization from nvme_init_ctrl to nvme_init_state - Fixed division by zero issue in calculation of vqfrt and vifrt capabilities Knut Omang (2): pcie: Add support for Single Root I/O Virtualization (SR/IOV) pcie: Add some SR/IOV API documentation in docs/pcie_sriov.txt Lukasz Maniak (4): hw/nvme: Add support for SR-IOV hw/nvme: Add support for Primary Controller Capabilities hw/nvme: Add support for Secondary Controller List docs: Add documentation for SR-IOV and Virtualization Enhancements Łukasz Gieryk (9): pcie: Add a helper to the SR/IOV API pcie: Add 1.2 version token for the Power Management Capability hw/nvme: Implement the Function Level Reset hw/nvme: Make max_ioqpairs and msix_qsize configurable in runtime hw/nvme: Remove reg_size variable and update BAR0 size calculation hw/nvme: Calculate BAR attributes in a function hw/nvme: Initialize capability structures for primary/secondary controllers hw/nvme: Add support for the Virtualization Management command hw/nvme: Update the initalization place for the AER queue docs/pcie_sriov.txt | 115 ++ docs/system/devices/nvme.rst | 82 + hw/nvme/ctrl.c | 674 --- hw/nvme/ns.c | 2 +- hw/nvme/nvme.h | 55 ++- hw/nvme/subsys.c | 75 +++- hw/nvme/trace-events | 6 + hw/pci/meson.build | 1 + hw/pci/pci.c | 100 -- hw/pci/pcie.c| 5 + hw/pci/pcie_sriov.c | 302 hw/pci/trace-events | 5 + include/block/nvme.h | 65 include/hw/pci/pci.h | 12 +- include/hw/pci/pci_ids.h | 1 + include/hw/pci/pci_regs.h| 1 + include/hw/pci/pcie.h| 6 + include/hw/pci/pcie_sriov.h | 77 include/qemu/typedefs.h | 2 + 19 files changed, 1505 insertions(+), 81 deletions(-) create mode 100644 docs/pcie_sriov.txt create mode 100644 hw/pci/pcie_sriov.c create mode 100644 include/hw/pci/pcie_sriov.h -- 2.25.1