Re: [PATCH v5 06/23] target/ppc: Tidy exception vs exit_tb

2021-05-17 Thread David Gibson
On Mon, May 17, 2021 at 05:50:08PM -0300, matheus.fe...@eldorado.org.br wrote:
> From: Richard Henderson 
> 
> We do not need to emit an exit_tb after an exception,
> as the latter will exit via longjmp.
> 
> Signed-off-by: Richard Henderson 
> Signed-off-by: Matheus Ferst 

Applied to ppc-for-6.1, thanks.

> ---
>  target/ppc/translate.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index 05e3c0417a..e68152810e 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -4648,8 +4648,9 @@ static void gen_lookup_and_goto_ptr(DisasContext *ctx)
>  } else if (sse & (CPU_SINGLE_STEP | CPU_BRANCH_STEP)) {
>  uint32_t excp = gen_prep_dbgex(ctx);
>  gen_exception(ctx, excp);
> +} else {
> +tcg_gen_exit_tb(NULL, 0);
>  }
> -tcg_gen_exit_tb(NULL, 0);
>  } else {
>  tcg_gen_lookup_and_goto_ptr();
>  }

-- 
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson


signature.asc
Description: PGP signature


[PATCH v5 06/23] target/ppc: Tidy exception vs exit_tb

2021-05-17 Thread matheus . ferst
From: Richard Henderson 

We do not need to emit an exit_tb after an exception,
as the latter will exit via longjmp.

Signed-off-by: Richard Henderson 
Signed-off-by: Matheus Ferst 
---
 target/ppc/translate.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index 05e3c0417a..e68152810e 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -4648,8 +4648,9 @@ static void gen_lookup_and_goto_ptr(DisasContext *ctx)
 } else if (sse & (CPU_SINGLE_STEP | CPU_BRANCH_STEP)) {
 uint32_t excp = gen_prep_dbgex(ctx);
 gen_exception(ctx, excp);
+} else {
+tcg_gen_exit_tb(NULL, 0);
 }
-tcg_gen_exit_tb(NULL, 0);
 } else {
 tcg_gen_lookup_and_goto_ptr();
 }
-- 
2.25.1