On Wed, 29 May 2024 07:15:30 +0200
Philippe Mathieu-Daudé wrote:
> 'legacy_align' is always NULL, remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé
> Reviewed-by: Thomas Huth
> Reviewed-by: David Hildenbrand
> Reviewed-by: Zhao Liu
Reviewed-by: Igor Mammedov
> ---
> include/hw/mem/pc-dimm.h | 3 +--
> hw/arm/virt.c| 2 +-
> hw/i386/pc.c | 2 +-
> hw/loongarch/virt.c | 2 +-
> hw/mem/pc-dimm.c | 6 ++
> hw/ppc/spapr.c | 2 +-
> 6 files changed, 7 insertions(+), 10 deletions(-)
>
> diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
> index 322bebe555..fe0f3ea963 100644
> --- a/include/hw/mem/pc-dimm.h
> +++ b/include/hw/mem/pc-dimm.h
> @@ -66,8 +66,7 @@ struct PCDIMMDeviceClass {
> void (*unrealize)(PCDIMMDevice *dimm);
> };
>
> -void pc_dimm_pre_plug(PCDIMMDevice *dimm, MachineState *machine,
> - const uint64_t *legacy_align, Error **errp);
> +void pc_dimm_pre_plug(PCDIMMDevice *dimm, MachineState *machine, Error
> **errp);
> void pc_dimm_plug(PCDIMMDevice *dimm, MachineState *machine);
> void pc_dimm_unplug(PCDIMMDevice *dimm, MachineState *machine);
> #endif
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 268b25e332..c7a1f754e7 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -2763,7 +2763,7 @@ static void virt_memory_pre_plug(HotplugHandler
> *hotplug_dev, DeviceState *dev,
> return;
> }
>
> -pc_dimm_pre_plug(PC_DIMM(dev), MACHINE(hotplug_dev), NULL, errp);
> +pc_dimm_pre_plug(PC_DIMM(dev), MACHINE(hotplug_dev), errp);
> }
>
> static void virt_memory_plug(HotplugHandler *hotplug_dev,
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 9cb5083f8f..08d38a1dcc 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1321,7 +1321,7 @@ static void pc_memory_pre_plug(HotplugHandler
> *hotplug_dev, DeviceState *dev,
> return;
> }
>
> -pc_dimm_pre_plug(PC_DIMM(dev), MACHINE(hotplug_dev), NULL, errp);
> +pc_dimm_pre_plug(PC_DIMM(dev), MACHINE(hotplug_dev), errp);
> }
>
> static void pc_memory_plug(HotplugHandler *hotplug_dev,
> diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c
> index 6a12659583..c8f16d9d6c 100644
> --- a/hw/loongarch/virt.c
> +++ b/hw/loongarch/virt.c
> @@ -1133,7 +1133,7 @@ static bool memhp_type_supported(DeviceState *dev)
> static void virt_mem_pre_plug(HotplugHandler *hotplug_dev, DeviceState *dev,
> Error **errp)
> {
> -pc_dimm_pre_plug(PC_DIMM(dev), MACHINE(hotplug_dev), NULL, errp);
> +pc_dimm_pre_plug(PC_DIMM(dev), MACHINE(hotplug_dev), errp);
> }
>
> static void virt_device_pre_plug(HotplugHandler *hotplug_dev,
> diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
> index 37f1f4ccfd..836384a90f 100644
> --- a/hw/mem/pc-dimm.c
> +++ b/hw/mem/pc-dimm.c
> @@ -44,8 +44,7 @@ static MemoryRegion *pc_dimm_get_memory_region(PCDIMMDevice
> *dimm, Error **errp)
> return host_memory_backend_get_memory(dimm->hostmem);
> }
>
> -void pc_dimm_pre_plug(PCDIMMDevice *dimm, MachineState *machine,
> - const uint64_t *legacy_align, Error **errp)
> +void pc_dimm_pre_plug(PCDIMMDevice *dimm, MachineState *machine, Error
> **errp)
> {
> Error *local_err = NULL;
> int slot;
> @@ -70,8 +69,7 @@ void pc_dimm_pre_plug(PCDIMMDevice *dimm, MachineState
> *machine,
> _abort);
> trace_mhp_pc_dimm_assigned_slot(slot);
>
> -memory_device_pre_plug(MEMORY_DEVICE(dimm), machine, legacy_align,
> - errp);
> +memory_device_pre_plug(MEMORY_DEVICE(dimm), machine, NULL, errp);
> }
>
> void pc_dimm_plug(PCDIMMDevice *dimm, MachineState *machine)
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 4345764bce..e7a5b7ce8c 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -3700,7 +3700,7 @@ static void spapr_memory_pre_plug(HotplugHandler
> *hotplug_dev, DeviceState *dev,
> return;
> }
>
> -pc_dimm_pre_plug(dimm, MACHINE(hotplug_dev), NULL, errp);
> +pc_dimm_pre_plug(dimm, MACHINE(hotplug_dev), errp);
> }
>
> struct SpaprDimmState {