RE: [PATCH v6 1/3] target-arm: Add support for Fujitsu A64FX

[ishii.shuuic...@fujitsu.com]

> I already gave my r-b on the last posting, but here it is again
> 
> Reviewed-by: Andrew Jones 

Sorry, We overlooked that.
Thank you:)

Best regards,

> -Original Message-
> From: Andrew Jones 
> Sent: Tuesday, August 31, 2021 7:20 PM
> To: Ishii, Shuuichirou/石井 周一郎 
> Cc: peter.mayd...@linaro.org; qemu-...@nongnu.org; qemu-devel@nongnu.org
> Subject: Re: [PATCH v6 1/3] target-arm: Add support for Fujitsu A64FX
> 
> On Tue, Aug 31, 2021 at 05:29:38PM +0900, Shuuichirou Ishii wrote:
> > Add a definition for the Fujitsu A64FX processor.
> >
> > The A64FX processor does not implement the AArch32 Execution state, so
> > there are no associated AArch32 Identification registers.
> >
> > For SVE, the A64FX processor supports only 128,256 and 512bit vector 
> > lengths.
> >
> > The Identification registers value are defined based on the FX700, and
> > have been tested and confirmed.
> >
> > Signed-off-by: Shuuichirou Ishii 
> > ---
> >  target/arm/cpu64.c | 48
> > ++
> >  1 file changed, 48 insertions(+)
> >
> 
> I already gave my r-b on the last posting, but here it is again
> 
> Reviewed-by: Andrew Jones 

Re: [PATCH v6 1/3] target-arm: Add support for Fujitsu A64FX

[Andrew Jones]

On Tue, Aug 31, 2021 at 05:29:38PM +0900, Shuuichirou Ishii wrote:
> Add a definition for the Fujitsu A64FX processor.
> 
> The A64FX processor does not implement the AArch32 Execution state,
> so there are no associated AArch32 Identification registers.
> 
> For SVE, the A64FX processor supports only 128,256 and 512bit vector lengths.
> 
> The Identification registers value are defined based on the FX700,
> and have been tested and confirmed.
> 
> Signed-off-by: Shuuichirou Ishii 
> ---
>  target/arm/cpu64.c | 48 ++
>  1 file changed, 48 insertions(+)
>

I already gave my r-b on the last posting, but here it is again

Reviewed-by: Andrew Jones 

[PATCH v6 1/3] target-arm: Add support for Fujitsu A64FX

[Shuuichirou Ishii]

Add a definition for the Fujitsu A64FX processor.

The A64FX processor does not implement the AArch32 Execution state,
so there are no associated AArch32 Identification registers.

For SVE, the A64FX processor supports only 128,256 and 512bit vector lengths.

The Identification registers value are defined based on the FX700,
and have been tested and confirmed.

Signed-off-by: Shuuichirou Ishii 
---
 target/arm/cpu64.c | 48 ++
 1 file changed, 48 insertions(+)

diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c
index 2f0cbddab5..15245a60a8 100644
--- a/target/arm/cpu64.c
+++ b/target/arm/cpu64.c
@@ -841,10 +841,58 @@ static void aarch64_max_initfn(Object *obj)
 cpu_max_set_sve_max_vq, NULL, NULL);
 }
 
+static void aarch64_a64fx_initfn(Object *obj)
+{
+ARMCPU *cpu = ARM_CPU(obj);
+
+cpu->dtb_compatible = "arm,a64fx";
+set_feature(>env, ARM_FEATURE_V8);
+set_feature(>env, ARM_FEATURE_NEON);
+set_feature(>env, ARM_FEATURE_GENERIC_TIMER);
+set_feature(>env, ARM_FEATURE_AARCH64);
+set_feature(>env, ARM_FEATURE_EL2);
+set_feature(>env, ARM_FEATURE_EL3);
+set_feature(>env, ARM_FEATURE_PMU);
+cpu->midr = 0x461f0010;
+cpu->revidr = 0x;
+cpu->ctr = 0x86668006;
+cpu->reset_sctlr = 0x3180;
+cpu->isar.id_aa64pfr0 =   0x00010111; /* No RAS Extensions */
+cpu->isar.id_aa64pfr1 = 0x;
+cpu->isar.id_aa64dfr0 = 0x10305408;
+cpu->isar.id_aa64dfr1 = 0x;
+cpu->id_aa64afr0 = 0x;
+cpu->id_aa64afr1 = 0x;
+cpu->isar.id_aa64mmfr0 = 0x1122;
+cpu->isar.id_aa64mmfr1 = 0x11212100;
+cpu->isar.id_aa64mmfr2 = 0x1011;
+cpu->isar.id_aa64isar0 = 0x10211120;
+cpu->isar.id_aa64isar1 = 0x00010001;
+cpu->isar.id_aa64zfr0 = 0x;
+cpu->clidr = 0x8023;
+cpu->ccsidr[0] = 0x7007e01c; /* 64KB L1 dcache */
+cpu->ccsidr[1] = 0x2007e01c; /* 64KB L1 icache */
+cpu->ccsidr[2] = 0x70ffe07c; /* 8MB L2 cache */
+cpu->dcz_blocksize = 6; /* 256 bytes */
+cpu->gic_num_lrs = 4;
+cpu->gic_vpribits = 5;
+cpu->gic_vprebits = 5;
+
+/* Suppport of A64FX's vector length are 128,256 and 512bit only */
+aarch64_add_sve_properties(obj);
+bitmap_zero(cpu->sve_vq_supported, ARM_MAX_VQ);
+set_bit(0, cpu->sve_vq_supported); /* 128bit */
+set_bit(1, cpu->sve_vq_supported); /* 256bit */
+set_bit(3, cpu->sve_vq_supported); /* 512bit */
+
+/* TODO:  Add A64FX specific HPC extension registers */
+}
+
 static const ARMCPUInfo aarch64_cpus[] = {
 { .name = "cortex-a57", .initfn = aarch64_a57_initfn },
 { .name = "cortex-a53", .initfn = aarch64_a53_initfn },
 { .name = "cortex-a72", .initfn = aarch64_a72_initfn },
+{ .name = "a64fx",  .initfn = aarch64_a64fx_initfn },
 { .name = "max",.initfn = aarch64_max_initfn },
 };
 
-- 
2.27.0