RE: [PULL 00/11] Ui patches
Hi Marc-André, > -Original Message- > From: Marc-André Lureau > Sent: Wednesday, May 15, 2024 3:44 AM > To: Michael Tokarev > Cc: qemu-devel@nongnu.org; qemu-stable ; > hikalium ; Kim, Dongwon > Subject: Re: [PULL 00/11] Ui patches > > Hi > > On Wed, May 15, 2024 at 2:29 PM Michael Tokarev wrote: > > > > 14.05.2024 16:17, marcandre.lur...@redhat.com wrote: > > > > > > UI: small fixes and improvements > > > > > > > > > > > > Bernhard Beschow (1): > > >ui/sdl2: Allow host to power down screen > > > > > > Dongwon Kim (7): > > >ui/gtk: Draw guest frame at refresh cycle > > >ui/gtk: Check if fence_fd is equal to or greater than 0 > > >ui/console: new dmabuf.h and dmabuf.c for QemuDmaBuf struct and > > > helpers > > >ui/console: Use qemu_dmabuf_get_..() helpers instead > > >ui/console: Use qemu_dmabuf_set_..() helpers instead > > >ui/console: Use qemu_dmabuf_new() and free() helpers instead > > >ui/console: move QemuDmaBuf struct def to dmabuf.c > > > > > > Sergii Zasenko (1): > > >Allow UNIX socket option for VNC websocket > > > > > > hikalium (2): > > >ui/gtk: Add gd_motion_event trace event > > >ui/gtk: Fix mouse/motion event scaling issue with GTK display > > > backend > > > > From this list, it looks like > > > >ui/gtk: Draw guest frame at refresh cycle > > I would allow a bit more time for this to be actually more widely tested. > > Dongwon, wdyt? [Kim, Dongwon] Ok, that sounds good to me. > > >ui/gtk: Check if fence_fd is equal to or greater than 0 > > (questionable, minor issue) > > minor, but fine in stable too. > > >ui/gtk: Fix mouse/motion event scaling issue with GTK display > > backend > > ok for stable imho (even though I don't like that we don't support hidpi > correctly, as I described in the patch review)
Re: [PULL 00/11] Ui patches
Hi On Wed, May 15, 2024 at 2:29 PM Michael Tokarev wrote: > > 14.05.2024 16:17, marcandre.lur...@redhat.com wrote: > > > > UI: small fixes and improvements > > > > > > > > Bernhard Beschow (1): > >ui/sdl2: Allow host to power down screen > > > > Dongwon Kim (7): > >ui/gtk: Draw guest frame at refresh cycle > >ui/gtk: Check if fence_fd is equal to or greater than 0 > >ui/console: new dmabuf.h and dmabuf.c for QemuDmaBuf struct and > > helpers > >ui/console: Use qemu_dmabuf_get_..() helpers instead > >ui/console: Use qemu_dmabuf_set_..() helpers instead > >ui/console: Use qemu_dmabuf_new() and free() helpers instead > >ui/console: move QemuDmaBuf struct def to dmabuf.c > > > > Sergii Zasenko (1): > >Allow UNIX socket option for VNC websocket > > > > hikalium (2): > >ui/gtk: Add gd_motion_event trace event > >ui/gtk: Fix mouse/motion event scaling issue with GTK display backend > > From this list, it looks like > >ui/gtk: Draw guest frame at refresh cycle I would allow a bit more time for this to be actually more widely tested. Dongwon, wdyt? >ui/gtk: Check if fence_fd is equal to or greater than 0 (questionable, > minor issue) minor, but fine in stable too. >ui/gtk: Fix mouse/motion event scaling issue with GTK display backend ok for stable imho (even though I don't like that we don't support hidpi correctly, as I described in the patch review)
Re: [PULL 00/11] Ui patches
14.05.2024 16:17, marcandre.lur...@redhat.com wrote: UI: small fixes and improvements Bernhard Beschow (1): ui/sdl2: Allow host to power down screen Dongwon Kim (7): ui/gtk: Draw guest frame at refresh cycle ui/gtk: Check if fence_fd is equal to or greater than 0 ui/console: new dmabuf.h and dmabuf.c for QemuDmaBuf struct and helpers ui/console: Use qemu_dmabuf_get_..() helpers instead ui/console: Use qemu_dmabuf_set_..() helpers instead ui/console: Use qemu_dmabuf_new() and free() helpers instead ui/console: move QemuDmaBuf struct def to dmabuf.c Sergii Zasenko (1): Allow UNIX socket option for VNC websocket hikalium (2): ui/gtk: Add gd_motion_event trace event ui/gtk: Fix mouse/motion event scaling issue with GTK display backend From this list, it looks like ui/gtk: Draw guest frame at refresh cycle ui/gtk: Check if fence_fd is equal to or greater than 0 (questionable, minor issue) ui/gtk: Fix mouse/motion event scaling issue with GTK display backend should be picked up for stable, is it not? Thanks, /mjt -- GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24. New key: rsa4096/61AD3D98ECDF2C8E 9D8B E14E 3F2A 9DD7 9199 28F1 61AD 3D98 ECDF 2C8E Old key: rsa2048/457CE0A0804465C5 6EE1 95D1 886E 8FFB 810D 4324 457C E0A0 8044 65C5 Transition statement: http://www.corpit.ru/mjt/gpg-transition-2024.txt
Re: [PULL 00/11] Ui patches
On 5/14/24 15:17, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau The following changes since commit 9360070196789cc8b9404b2efaf319384e64b107: Merge tag 'for-upstream' ofhttps://gitlab.com/bonzini/qemu into staging (2024-05-12 13:41:26 +0200) are available in the Git repository at: https://gitlab.com/marcandre.lureau/qemu.git tags/ui-pull-request for you to fetch changes up to 2e701e6785cd8cc048c608751c6e4f6253c67ab6: ui/sdl2: Allow host to power down screen (2024-05-14 17:14:13 +0400) UI: small fixes and improvements Applied, thanks. Please update https://wiki.qemu.org/ChangeLog/9.1 as appropriate. r~
[PULL 00/11] Ui patches
From: Marc-André Lureau The following changes since commit 9360070196789cc8b9404b2efaf319384e64b107: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2024-05-12 13:41:26 +0200) are available in the Git repository at: https://gitlab.com/marcandre.lureau/qemu.git tags/ui-pull-request for you to fetch changes up to 2e701e6785cd8cc048c608751c6e4f6253c67ab6: ui/sdl2: Allow host to power down screen (2024-05-14 17:14:13 +0400) UI: small fixes and improvements Bernhard Beschow (1): ui/sdl2: Allow host to power down screen Dongwon Kim (7): ui/gtk: Draw guest frame at refresh cycle ui/gtk: Check if fence_fd is equal to or greater than 0 ui/console: new dmabuf.h and dmabuf.c for QemuDmaBuf struct and helpers ui/console: Use qemu_dmabuf_get_..() helpers instead ui/console: Use qemu_dmabuf_set_..() helpers instead ui/console: Use qemu_dmabuf_new() and free() helpers instead ui/console: move QemuDmaBuf struct def to dmabuf.c Sergii Zasenko (1): Allow UNIX socket option for VNC websocket hikalium (2): ui/gtk: Add gd_motion_event trace event ui/gtk: Fix mouse/motion event scaling issue with GTK display backend include/hw/vfio/vfio-common.h | 2 +- include/hw/virtio/virtio-gpu.h | 4 +- include/ui/console.h| 20 +-- include/ui/dmabuf.h | 49 +++ hw/display/vhost-user-gpu.c | 32 +++-- hw/display/virtio-gpu-udmabuf.c | 27 ++-- hw/vfio/display.c | 32 ++--- ui/console.c| 4 +- ui/dbus-console.c | 9 +- ui/dbus-listener.c | 71 +- ui/dmabuf.c | 229 ui/egl-headless.c | 23 +++- ui/egl-helpers.c| 59 ui/gtk-egl.c| 53 +--- ui/gtk-gl-area.c| 42 -- ui/gtk.c| 32 +++-- ui/sdl2.c | 1 + ui/spice-display.c | 50 --- ui/vnc.c| 5 - qemu-options.hx | 4 + ui/meson.build | 1 + ui/trace-events | 1 + 22 files changed, 547 insertions(+), 203 deletions(-) create mode 100644 include/ui/dmabuf.h create mode 100644 ui/dmabuf.c -- 2.41.0.28.gd7d8841f67
