Re: [PULL 00/30] gdbstub refactor for smaller build

2023-03-09 Thread Peter Maydell
On Tue, 7 Mar 2023 at 21:21, Alex Bennée  wrote:
>
> The following changes since commit 9832009d9dd2386664c15cc70f6e6bfe062be8bd:
>
>   Merge tag 'pull-riscv-to-apply-20230306' of 
> https://gitlab.com/palmer-dabbelt/qemu into staging (2023-03-07 12:53:00 
> +)
>
> are available in the Git repository at:
>
>   https://gitlab.com/stsquad/qemu.git tags/pull-gdbstub-070323-3
>
> for you to fetch changes up to 412ae12647d1086c713e13841fd25d10d5418c7f:
>
>   gdbstub: move update guest debug to accel ops (2023-03-07 20:44:09 +)
>
> 
> gdbstub refactor:
>
>   - split user and softmmu code
>   - use cleaner headers for tb_flush, target_ulong
>   - probe for gdb multiarch support at configure
>   - make syscall handling target independent
>   - add update guest debug of accel ops


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/8.0
for any user-visible changes.

-- PMM



[PULL 00/30] gdbstub refactor for smaller build

2023-03-07 Thread Alex Bennée
The following changes since commit 9832009d9dd2386664c15cc70f6e6bfe062be8bd:

  Merge tag 'pull-riscv-to-apply-20230306' of 
https://gitlab.com/palmer-dabbelt/qemu into staging (2023-03-07 12:53:00 +)

are available in the Git repository at:

  https://gitlab.com/stsquad/qemu.git tags/pull-gdbstub-070323-3

for you to fetch changes up to 412ae12647d1086c713e13841fd25d10d5418c7f:

  gdbstub: move update guest debug to accel ops (2023-03-07 20:44:09 +)


gdbstub refactor:

  - split user and softmmu code
  - use cleaner headers for tb_flush, target_ulong
  - probe for gdb multiarch support at configure
  - make syscall handling target independent
  - add update guest debug of accel ops


Alex Bennée (25):
  gdbstub/internals.h: clean up include guard
  gdbstub: fix-up copyright and license files
  gdbstub: clean-up indent on gdb_exit
  gdbstub: define separate user/system structures
  gdbstub: move GDBState to shared internals header
  includes: move tb_flush into its own header
  gdbstub: move fromhex/tohex routines to internals
  gdbstub: make various helpers visible to the rest of the module
  gdbstub: move chunk of softmmu functionality to own file
  gdbstub: move chunks of user code into own files
  gdbstub: rationalise signal mapping in softmmu
  gdbstub: abstract target specific details from gdb_put_packet_binary
  gdbstub: specialise handle_query_attached
  gdbstub: specialise target_memory_rw_debug
  gdbstub: introduce gdb_get_max_cpus
  gdbstub: specialise stub_can_reverse
  gdbstub: fix address type of gdb_set_cpu_pc
  gdbstub: don't use target_ulong while handling registers
  gdbstub: move register helpers into standalone include
  gdbstub: move syscall handling to new file
  gdbstub: only compile gdbstub twice for whole build
  testing: probe gdb for supported architectures ahead of time
  include: split target_long definition from cpu-defs
  gdbstub: split out softmmu/user specifics for syscall handling
  stubs: split semihosting_get_target from system only stubs

Mads Ynddal (1):
  gdbstub: move update guest debug to accel ops

Philippe Mathieu-Daudé (1):
  gdbstub: Make syscall_complete/[gs]et_reg target-agnostic typedefs

Richard Henderson (3):
  gdbstub: Remove gdb_do_syscallv
  gdbstub: Adjust gdb_do_syscall to only use uint32_t and uint64_t
  gdbstub: Build syscall.c once

 MAINTAINERS|4 +
 configure  |8 +
 gdbstub/internals.h|  212 ++-
 include/exec/cpu-defs.h|   19 +-
 include/exec/exec-all.h|1 -
 include/exec/gdbstub.h |  208 ---
 include/exec/target_long.h |   42 +
 include/exec/tb-flush.h|   26 +
 include/gdbstub/helpers.h  |  103 ++
 include/gdbstub/syscalls.h |  113 ++
 include/gdbstub/user.h |   43 +
 include/sysemu/accel-ops.h |1 +
 linux-user/user-internals.h|1 +
 accel/kvm/kvm-accel-ops.c  |8 +
 accel/stubs/tcg-stub.c |1 +
 accel/tcg/tb-maint.c   |1 +
 accel/tcg/translate-all.c  |1 +
 bsd-user/freebsd/os-syscall.c  |2 +
 bsd-user/main.c|1 +
 bsd-user/signal.c  |1 +
 cpu.c  |   12 +-
 gdbstub/gdbstub.c  | 1655 ++--
 gdbstub/softmmu.c  |  603 ++-
 gdbstub/syscalls.c |  205 +++
 gdbstub/user-target.c  |  283 
 gdbstub/user.c |  423 -
 hw/ppc/spapr_hcall.c   |1 +
 linux-user/exit.c  |2 +-
 linux-user/main.c  |1 +
 linux-user/signal.c|2 +-
 plugins/core.c |1 +
 plugins/loader.c   |2 +-
 semihosting/arm-compat-semi.c  |1 +
 semihosting/guestfd.c  |2 +-
 semihosting/syscalls.c |   37 +-
 softmmu/runstate.c |2 +-
 stubs/semihost-all.c   |   17 +
 stubs/semihost.c   |5 -
 target/alpha/gdbstub.c