Re: [PULL 00/61] Misc patches for soft freeze
Patchew URL:
https://patchew.org/QEMU/1584394048-44994-1-git-send-email-pbonz...@redhat.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===
PASS 1 fdc-test /x86_64/fdc/cmos
PASS 2 fdc-test /x86_64/fdc/no_media_on_start
PASS 3 fdc-test /x86_64/fdc/read_without_media
==11429==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 4 fdc-test /x86_64/fdc/media_change
PASS 5 fdc-test /x86_64/fdc/sense_interrupt
PASS 6 fdc-test /x86_64/fdc/relative_seek
---
PASS 32 test-opts-visitor /visitor/opts/range/beyond
PASS 33 test-opts-visitor /visitor/opts/dict/unvisited
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-coroutine -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-coroutine"
==11484==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
==11484==WARNING: ASan is ignoring requested __asan_handle_no_return: stack
top: 0x7ffda0e6; bottom 0x7fa1c9d2; size: 0x005bd714 (394450436096)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 1 test-coroutine /basic/no-dangling-access
---
PASS 12 fdc-test /x86_64/fdc/read_no_dma_19
PASS 13 fdc-test /x86_64/fdc/fuzz-registers
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 QTEST_QEMU_IMG=qemu-img
tests/qtest/ide-test -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="ide-test"
==11499==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 14 test-aio /aio/timer/schedule
PASS 15 test-aio /aio/coroutine/queue-chaining
PASS 16 test-aio /aio-gsource/flush
---
PASS 25 test-aio /aio-gsource/event/wait
PASS 26 test-aio /aio-gsource/event/flush
PASS 27 test-aio /aio-gsource/event/wait/no-flush-cb
==11507==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 ide-test /x86_64/ide/identify
==11513==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 28 test-aio /aio-gsource/timer/schedule
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-aio-multithread -m=quick -k --tap < /dev/null |
./scripts/tap-driver.pl --test-name="test-aio-multithread"
==11520==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-aio-multithread /aio/multi/lifecycle
PASS 2 ide-test /x86_64/ide/flush
==11533==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 2 test-aio-multithread /aio/multi/schedule
PASS 3 ide-test /x86_64/ide/bmdma/simple_rw
==11544==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 4 ide-test /x86_64/ide/bmdma/trim
PASS 3 test-aio-multithread /aio/multi/mutex/contended
==11550==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 4 test-aio-multithread /aio/multi/mutex/handoff
PASS 5 test-aio-multithread /aio/multi/mutex/mcs
PASS 6 test-aio-multithread /aio/multi/mutex/pthread
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-throttle -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-throttle"
==11572==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-throttle /throttle/leak_bucket
PASS 2 test-throttle /throttle/compute_wait
PASS 3 test-throttle /throttle/init
---
PASS 14 test-throttle /throttle/config/max
PASS 15 test-throttle /throttle/config/iops_size
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-thread-pool -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-thread-pool"
==11576==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-thread-pool /thread-pool/submit
PASS 2 test-thread-pool /thread-pool/submit-aio
PASS 3 test-thread-pool /thread-pool/submit-co
PASS 4 test-thread-pool /thread-pool/submit-many
==11643==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 5 test-thread-pool /thread-pool/cancel
PASS 6 test-thread-pool /thread-pool/cancel-async
Re: [PULL 00/61] Misc patches for soft freeze
Patchew URL:
https://patchew.org/QEMU/1584394048-44994-1-git-send-email-pbonz...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PULL 00/61] Misc patches for soft freeze
Message-id: 1584394048-44994-1-git-send-email-pbonz...@redhat.com
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
cd46cc2 hw/arm: Let devices own the MemoryRegion they create
acefd47 hw/arm: Remove unnecessary memory_region_set_readonly() on ROM alias
f26c6ec hw/ppc/ppc405: Use memory_region_init_rom() with read-only regions
014a7f6 hw/arm/stm32: Use memory_region_init_rom() with read-only regions
37b937c hw/char: Let devices own the MemoryRegion they create
5faaec9 hw/riscv: Let devices own the MemoryRegion they create
32e8210 hw/dma: Let devices own the MemoryRegion they create
41b0949 hw/display: Let devices own the MemoryRegion they create
2440d3d hw/core: Let devices own the MemoryRegion they create
cbb4826 scripts/cocci: Patch to let devices own their MemoryRegions
78397a0 scripts/cocci: Patch to remove unnecessary memory_region_set_readonly()
7105f13 scripts/cocci: Patch to detect potential use of memory_region_init_rom
5e29657 hw/sparc: Use memory_region_init_rom() with read-only regions
3eb227a hw/sh4: Use memory_region_init_rom() with read-only regions
eb09349 hw/riscv: Use memory_region_init_rom() with read-only regions
ed4826e hw/ppc: Use memory_region_init_rom() with read-only regions
b105369 hw/pci-host: Use memory_region_init_rom() with read-only regions
a68500f hw/net: Use memory_region_init_rom() with read-only regions
ed9cd1f hw/m68k: Use memory_region_init_rom() with read-only regions
399ba06 hw/display: Use memory_region_init_rom() with read-only regions
51d745b hw/arm: Use memory_region_init_rom() with read-only regions
933a6c5 scripts/cocci: Patch to replace memory_region_init_{ram, readonly ->
rom}
4fed855 scripts/cocci: Rename memory-region-{init-ram -> housekeeping}
af2a719 memory: Simplify memory_region_init_rom_nomigrate() to ease review
af1e8ca memory: Correctly return alias region type
420272a lockable: add QemuRecMutex support
7145da7 lockable: add lock guards
773b436 cpus: avoid pause_all_vcpus getting stuck due to race
3c6d277 exec/rom_reset: Free rom data during inmigrate skip
46cca43 Use -isystem for linux-headers dir
5e28455 softmmu/vl.c: Handle '-cpu help' and '-device help' before 'no default
machine'
cbe6b04 qemu-cpu-models.rst: Document -noTSX, mds-no, taa-no, and tsx-ctrl
fda402f ui/curses: Move arrays to .heap to save 74KiB of .bss
d5573ac ui/curses: Make control_characters[] array const
7c3e49f hw/usb/quirks: Use smaller types to reduce .rodata by 10KiB
c87784b hw/audio/intel-hda: Use memory region alias to reduce .rodata by 4.34MB
cc21b87 hw/audio/fmopl: Move ENV_CURVE to .heap to save 32KiB of .bss
a1ea1d5 Makefile: Let the 'help' target list the tools targets
9ac297a Makefile: Align 'help' target output
b3219e5 WHPX: Use proper synchronization primitives while processing
7feeb33 i386: Fix GCC warning with snprintf when HAX is enabled
1ea8875 qom/object: Use common get/set uint helpers
7e7ce48 ich9: Simplify ich9_lpc_initfn
a5caa86 ich9: fix getter type for sci_int property
65692c6 qom/object: enable setter for uint types
f78a8b0 memory: Fix start offset for bitmap log_clear hook
bbb0d03 tests/docker: Install SASL library to extend code coverage on amd64
0b44062 configure: Fix building with SASL on Windows
59337c0 modules: load modules from versioned /var/run dir
3108fd7 build-sys: do not make qemu-ga link with pixman
4668b2a oslib-posix: initialize mutex and condition variable
374e906 hw/i386/intel_iommu: Fix out-of-bounds access on guest IRT
91ae0b7 MAINTAINERS: Add entry for Guest X86 HAXM CPUs
b75790f WHPX: Use QEMU values for trapped CPUID
6b4d015 WHPX: TSC get and set should be dependent on VM state
31dab17 util: add util function buffer_zero_avx512()
1af2201 configure: add configure option avx512f_opt
c80c8bc misc: Replace zero-length arrays with flexible array member (manual)
cda1965 misc: Replace zero-length arrays with flexible array member (automatic)
c231a41 optionrom/pvh: scan entire RSDP Area
ac0f826 scsi/qemu-pr-helper: Fix out-of-bounds access to trnptid_list[]
=== OUTPUT BEGIN ===
1/61 Checking commit ac0f8263e015 (scsi/qemu-pr-helper: Fix out-of-bounds
access to trnptid_list[])
2/61 Checking commit c231a414ecc4 (optionrom/pvh: scan entire RSDP Area)
3/61 Checking commit cda196559230 (misc: Replace zero-length arrays with
flexible array member (automatic))
4/61 Checking commit c80c8bc2cfc5 (misc: Replace zero-length arrays with
flexible array member (manual))
5/61 Checking commit 1af220199ceb (configure: add configure option avx51
[PULL 00/61] Misc patches for soft freeze
The following changes since commit a98135f727595382e200d04c2996e868b7925a01:
Merge remote-tracking branch 'remotes/kraxel/tags/vga-20200316-pull-request'
into staging (2020-03-16 14:55:59 +)
are available in the git repository at:
git://github.com/bonzini/qemu.git tags/for-upstream
for you to fetch changes up to 39633510cca6dee4129258c3ba8fb4a677cc65fd:
hw/arm: Let devices own the MemoryRegion they create (2020-03-16 22:07:52
+0100)
* Bugfixes all over the place
* get/set_uint cleanups (Felipe)
* Lock guard support (Stefan)
* MemoryRegion ownership cleanup (Philippe)
Christian Ehrhardt (1):
modules: load modules from versioned /var/run dir
Christophe de Dinechin (1):
scsi/qemu-pr-helper: Fix out-of-bounds access to trnptid_list[]
Colin Xu (1):
MAINTAINERS: Add entry for Guest X86 HAXM CPUs
Dr. David Alan Gilbert (1):
exec/rom_reset: Free rom data during inmigrate skip
Eduardo Habkost (1):
Use -isystem for linux-headers dir
Felipe Franciosi (4):
qom/object: enable setter for uint types
ich9: fix getter type for sci_int property
ich9: Simplify ich9_lpc_initfn
qom/object: Use common get/set uint helpers
Jan Kiszka (1):
hw/i386/intel_iommu: Fix out-of-bounds access on guest IRT
Joe Richey (1):
optionrom/pvh: scan entire RSDP Area
Julio Faracco (1):
i386: Fix GCC warning with snprintf when HAX is enabled
Kashyap Chamarthy (1):
qemu-cpu-models.rst: Document -noTSX, mds-no, taa-no, and tsx-ctrl
Longpeng (Mike) (1):
cpus: avoid pause_all_vcpus getting stuck due to race
Marc-André Lureau (1):
build-sys: do not make qemu-ga link with pixman
Matt Borgerson (1):
memory: Fix start offset for bitmap log_clear hook
Paolo Bonzini (1):
oslib-posix: initialize mutex and condition variable
Peter Maydell (1):
softmmu/vl.c: Handle '-cpu help' and '-device help' before 'no default
machine'
Philippe Mathieu-Daudé (36):
misc: Replace zero-length arrays with flexible array member (automatic)
misc: Replace zero-length arrays with flexible array member (manual)
configure: Fix building with SASL on Windows
tests/docker: Install SASL library to extend code coverage on amd64
Makefile: Align 'help' target output
Makefile: Let the 'help' target list the tools targets
hw/audio/fmopl: Move ENV_CURVE to .heap to save 32KiB of .bss
hw/audio/intel-hda: Use memory region alias to reduce .rodata by 4.34MB
hw/usb/quirks: Use smaller types to reduce .rodata by 10KiB
ui/curses: Make control_characters[] array const
ui/curses: Move arrays to .heap to save 74KiB of .bss
memory: Correctly return alias region type
memory: Simplify memory_region_init_rom_nomigrate() to ease review
scripts/cocci: Rename memory-region-{init-ram -> housekeeping}
scripts/cocci: Patch to replace memory_region_init_{ram,readonly -> rom}
hw/arm: Use memory_region_init_rom() with read-only regions
hw/display: Use memory_region_init_rom() with read-only regions
hw/m68k: Use memory_region_init_rom() with read-only regions
hw/net: Use memory_region_init_rom() with read-only regions
hw/pci-host: Use memory_region_init_rom() with read-only regions
hw/ppc: Use memory_region_init_rom() with read-only regions
hw/riscv: Use memory_region_init_rom() with read-only regions
hw/sh4: Use memory_region_init_rom() with read-only regions
hw/sparc: Use memory_region_init_rom() with read-only regions
scripts/cocci: Patch to detect potential use of memory_region_init_rom
scripts/cocci: Patch to remove unnecessary memory_region_set_readonly()
scripts/cocci: Patch to let devices own their MemoryRegions
hw/core: Let devices own the MemoryRegion they create
hw/display: Let devices own the MemoryRegion they create
hw/dma: Let devices own the MemoryRegion they create
hw/riscv: Let devices own the MemoryRegion they create
hw/char: Let devices own the MemoryRegion they create
hw/arm/stm32: Use memory_region_init_rom() with read-only regions
hw/ppc/ppc405: Use memory_region_init_rom() with read-only regions
hw/arm: Remove unnecessary memory_region_set_readonly() on ROM alias
hw/arm: Let devices own the MemoryRegion they create
Robert Hoo (2):
configure: add configure option avx512f_opt
util: add util function buffer_zero_avx512()
Stefan Hajnoczi (2):
lockable: add lock guards
lockable: add QemuRecMutex support
Sunil Muthuswamy (3):
WHPX: TSC get and set should be dependent on VM state
WHPX: Use QEMU values for trapped CPUID
WHPX: Use proper synchronization primitives while processing
MAINTAINERS| 12 ++
Makefile
