Re: [QEMU-DEVEL][PATCH] gpio: fix memory leak in aspeed_gpio_init()

[Cédric Le Goater]

On 18/11/2019 02:37, pannengy...@huawei.com wrote:
> From: PanNengyuan 
> 
> Address Sanitizer shows memory leak in hw/gpio/aspeed_gpio.c:875
> 
> Reported-by: Euler Robot 
> Signed-off-by: PanNengyuan 

Reviewed-by: Cédric Le Goater  

I will add this patch the series I am building for 5.0.

Thanks,

C.

> ---
>  hw/gpio/aspeed_gpio.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c
> index 7acc5fa..41e11ea 100644
> --- a/hw/gpio/aspeed_gpio.c
> +++ b/hw/gpio/aspeed_gpio.c
> @@ -876,6 +876,7 @@ static void aspeed_gpio_init(Object *obj)
> pin_idx % GPIOS_PER_GROUP);
>  object_property_add(obj, name, "bool", aspeed_gpio_get_pin,
>  aspeed_gpio_set_pin, NULL, NULL, NULL);
> +g_free(name);
>  }
>  }
>  
> 

[QEMU-DEVEL][PATCH] gpio: fix memory leak in aspeed_gpio_init()

[pannengyuan]

From: PanNengyuan 

Address Sanitizer shows memory leak in hw/gpio/aspeed_gpio.c:875

Reported-by: Euler Robot 
Signed-off-by: PanNengyuan 
---
 hw/gpio/aspeed_gpio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c
index 7acc5fa..41e11ea 100644
--- a/hw/gpio/aspeed_gpio.c
+++ b/hw/gpio/aspeed_gpio.c
@@ -876,6 +876,7 @@ static void aspeed_gpio_init(Object *obj)
pin_idx % GPIOS_PER_GROUP);
 object_property_add(obj, name, "bool", aspeed_gpio_get_pin,
 aspeed_gpio_set_pin, NULL, NULL, NULL);
+g_free(name);
 }
 }
 
-- 
2.7.2.windows.1